fix: treat paragraphs with inline leaf nodes as non-empty#3213
Draft
bukinoshita wants to merge 1 commit intocanaryfrom
Draft
fix: treat paragraphs with inline leaf nodes as non-empty#3213bukinoshita wants to merge 1 commit intocanaryfrom
bukinoshita wants to merge 1 commit intocanaryfrom
Conversation
…empty Change isEmptyParagraph to check node.childCount === 0 instead of node.textContent.length === 0. ProseMirror's textContent ignores inline leaf nodes like hardBreak, causing paragraphs containing only a hardBreak to be incorrectly classified as empty. Resolves BU-669 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
commit: |
cursor
bot
changed the title
gabrielmfern
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes editor empty-state detection by treating paragraphs with inline leaf nodes (e.g.,
hardBreak) as non-empty. Prevents placeholders or disabled actions when the document only has visible line breaks. Resolves BU-669.isEmptyParagraphto usenode.childCount === 0instead ofnode.textContent.length === 0(ProseMirrortextContentignores inline leaf nodes).hardBreak(alone, with text, insidecontainer);isEditorEmptynow stays false when visible breaks exist.Written for commit 0874255. Summary will update on new commits.