fix(editor): Strip trailing empty paragraphs from containers at serialization time#3221
Draft
bukinoshita wants to merge 1 commit intocanaryfrom
Draft
fix(editor): Strip trailing empty paragraphs from containers at serialization time#3221bukinoshita wants to merge 1 commit intocanaryfrom
bukinoshita wants to merge 1 commit intocanaryfrom
Conversation
The TrailingNode extension auto-inserts empty paragraphs into containers for editing UX, but these were serialized into the final email HTML as <p><br/></p>, adding unintended vertical spacing after non-paragraph blocks (buttons, images, dividers). This fix adds a stripTrailingEmptyParagraphs utility that recursively removes trailing empty paragraphs from container nodes during serialization in composeReactEmail. The editing experience is preserved since the fix only applies at export time. Resolves BU-668 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Strip trailing empty paragraphs from
containernodes during serialization to prevent<p><br/></p>in exported emails. This removes extra space after buttons, images, and dividers without changing the editor UX and addresses BU-668.stripTrailingEmptyParagraphsand invoke it incomposeReactEmailto remove only trailing empty paragraphs fromcontainernodes (keeps one if it’s the only child; preserves content).TrailingNodeand stops unintended vertical spacing in final HTML.Written for commit daac083. Summary will update on new commits.