fix: propagate downstream failure status in webhook forwarding#227
Merged
felipefreitag merged 5 commits intomainfrom Apr 14, 2026
Merged
fix: propagate downstream failure status in webhook forwarding#227felipefreitag merged 5 commits intomainfrom
felipefreitag merged 5 commits intomainfrom
Conversation
When --forward-to is set, the listener now returns the downstream HTTP status to Resend instead of always returning 200 OK. This preserves Resend's retry behavior when the local handler fails. - Non-2xx downstream responses are propagated as-is to the upstream - Forwarding errors (connection refused, timeout) return 502 - Added AbortSignal.timeout(30s) to prevent stalled forwarding - Extracted resolveUpstream to its own utility file Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/commands/webhooks/listen-forward.test.ts">
<violation number="1" location="tests/commands/webhooks/listen-forward.test.ts:79">
P2: This AbortController is never wired into the listener, so aborting it in teardown does nothing and the test leaks the background server.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
- Export ForwardResult type from resolve-upstream and reuse in listen.ts - Detect AbortSignal timeout (DOMException/TimeoutError) and map to 504 - Wrap request handler in try/catch to prevent unhandled rejections from readBody
felipefreitag
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Propagates downstream HTTP status when
--forward-tois used so Resend retries on local handler failures. Addresses BU-649 by stopping the always-200 OK behavior.Bug Fixes
AbortSignal.timeoutto prevent hangs.Refactors
resolve-upstream.tsto map forward results to upstream responses.Written for commit 4a4346b. Summary will update on new commits.