fix: handle domain fetch failure without defaulting to onboarding sender#230
Draft
bukinoshita wants to merge 2 commits intomainfrom
Draft
fix: handle domain fetch failure without defaulting to onboarding sender#230bukinoshita wants to merge 2 commits intomainfrom
bukinoshita wants to merge 2 commits intomainfrom
Conversation
- Change fetchVerifiedDomains to return null on error instead of [], distinguishing 'no verified domains' from 'fetch failed' - Add pagination support to fetchVerifiedDomains using recursive page collection via has_more/after cursors - When domain fetch fails in emails send, warn the user and prompt for an explicit sender address without pre-filling onboarding@resend.dev - Apply the same fix to broadcasts create command - Add comprehensive tests for fetchVerifiedDomains covering pagination, error handling, and domain filtering Resolves BU-613 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Member
Author
|
@cursor fix conflict |
|
The PR description was edited by humans/cubic. I'll preserve it as-is — no need to update since nothing changed in the PR scope, just a conflict resolution merge. The PR is now conflict-free. Resolved the merge conflict in
All 794 tests pass, typecheck and lint are clean. Pushed to PR #230.   |
Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fix interactive sends so a domain fetch failure no longer defaults to
onboarding@resend.dev. We now warn and require an explicit From address, and paginate domain listing to find all verified sending domains.Bug Fixes
fetchVerifiedDomainsreturnsnullon API errors or exceptions to distinguish failure from “no domains”.emails sendandbroadcasts createwarn on failure and prompt for From without a default.nullon failures.New Features
has_more/afterto collect all verified sending domains.Written for commit 9907675. Summary will update on new commits.