fix: add 30s request timeout to withSpinner to prevent hanging CLI commands#237
Open
bukinoshita wants to merge 6 commits intomainfrom
Open
fix: add 30s request timeout to withSpinner to prevent hanging CLI commands#237bukinoshita wants to merge 6 commits intomainfrom
bukinoshita wants to merge 6 commits intomainfrom
Conversation
…mmands Adds a withTimeout utility that wraps SDK call promises with a 30-second deadline. When the timeout expires, the promise rejects with a structured error that flows through the existing error handling in withSpinner. This prevents contact commands (and all other SDK-backed commands) from hanging indefinitely when the upstream API is slow or unresponsive. Resolves BU-640 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
Member
Author
|
@cubic-dev-ai can you review? |
Contributor
@bukinoshita I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/lib/spinner.ts">
<violation number="1" location="src/lib/spinner.ts:71">
P1: Timeout handling does not cancel the underlying SDK request, so timed-out commands may still complete remotely.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| try { | ||
| for (let attempt = 0; ; attempt++) { | ||
| const { data, error, headers } = await call(); | ||
| const { data, error, headers } = await withTimeout( |
Contributor
There was a problem hiding this comment.
P1: Timeout handling does not cancel the underlying SDK request, so timed-out commands may still complete remotely.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/spinner.ts, line 71:
<comment>Timeout handling does not cancel the underlying SDK request, so timed-out commands may still complete remotely.</comment>
<file context>
@@ -67,7 +68,10 @@ export async function withSpinner<T>(
try {
for (let attempt = 0; ; attempt++) {
- const { data, error, headers } = await call();
+ const { data, error, headers } = await withTimeout(
+ call(),
+ REQUEST_TIMEOUT_MS,
</file context>
`test` is not imported from vitest and globals are not enabled, causing a ReferenceError that crashes the entire spinner test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add a 30s request timeout to
withSpinnerso CLI commands fail fast instead of hanging when the API is slow.withTimeoututility withREQUEST_TIMEOUT_MS = 30_000.withSpinnerwith the timeout; allwithSpinner-based commands are now bounded.withTimeoutand timeout handling inwithSpinner.Written for commit 6d98a55. Summary will update on new commits.