[codex] Add analysis graph hooks for ndarray features#29
Draft
colonelpanic8 wants to merge 3 commits into
Draft
Conversation
1fdde78 to
880672c
Compare
880672c to
02fbe9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NDArrayCollectorbuild and evaluate one shared analysis graph from the union of feature-adder dependencies.Validation
cargo test analysis_feature_adders_share_one_graph_evaluation_per_ndarray_rowcargo test --libcargo testcurrently hits a pre-existingtests/stats_frame_resolution_test.rsfailure:events.boost_pickups.len: left=0, right=557; reproduced on cleanorigin/master.