[codex] Abstract collector processor view#34
Closed
colonelpanic8 wants to merge 1 commit into
Closed
Conversation
838f496 to
998955a
Compare
Contributor
Author
|
Closing as superseded: the collector ProcessorView abstraction and shared FrameInput sampling work have already landed on master through later changes, and this draft branch no longer merges cleanly into current master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessorViewtrait implemented byReplayProcessor&dyn ProcessorViewinstead of&ReplayProcessorFrameInputown sampled state instead of carrying a concrete processor pointerImpact
Collectors now depend on an abstract processor-like interface, which should make it easier to drive the same collector/stat pipeline from another state source such as BakkesMod later. Replay traversal and mutation still stay on
ReplayProcessor.Validation
cargo checkcargo testcargo clippy --all-targets --all-features -- -D warnings