Skip to content

[codex] Abstract collector processor view#34

Closed
colonelpanic8 wants to merge 1 commit into
masterfrom
colonelpanic/abstract-processor-interface
Closed

[codex] Abstract collector processor view#34
colonelpanic8 wants to merge 1 commit into
masterfrom
colonelpanic/abstract-processor-interface

Conversation

@colonelpanic8
Copy link
Copy Markdown
Contributor

Summary

  • add a read-only ProcessorView trait implemented by ReplayProcessor
  • switch collectors, ndarray feature adders, stats calculators, and test collectors to consume &dyn ProcessorView instead of &ReplayProcessor
  • replace collector-side direct event-vector field access with view methods and make FrameInput own sampled state instead of carrying a concrete processor pointer

Impact

Collectors now depend on an abstract processor-like interface, which should make it easier to drive the same collector/stat pipeline from another state source such as BakkesMod later. Replay traversal and mutation still stay on ReplayProcessor.

Validation

  • cargo check
  • cargo test
  • pre-commit hook: cargo clippy --all-targets --all-features -- -D warnings

@colonelpanic8 colonelpanic8 force-pushed the colonelpanic/abstract-processor-interface branch from 838f496 to 998955a Compare May 25, 2026 05:04
@colonelpanic8
Copy link
Copy Markdown
Contributor Author

Closing as superseded: the collector ProcessorView abstraction and shared FrameInput sampling work have already landed on master through later changes, and this draft branch no longer merges cleanly into current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant