Refactor calculators to emit event-derived stats#42
Merged
Conversation
5385b09 to
635e08e
Compare
635e08e to
b0f8abb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Calculators should be responsible for detecting events and state changes. Summary stats are now derived separately from those event streams, which keeps detection logic and aggregation logic easier to reason about independently.
Validation
Note: one earlier full cargo test run hit a non-reproduced native allocator abort in post_eac_replay_fixture_test. The isolated failing test and a full rerun both passed cleanly.