Skip to content

fix (analysis): Obey openFilesOnly in analysis #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petrieh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix (analysis): Obey openFilesOnly in analysis #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/language_server/src/robotcode/language_server/common/parts/diagnostics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,15 @@ def run_workspace_diagnostics(self) -> None:
self._break_diagnostics_loop_event.clear()

documents = sorted(
[doc for doc in self.parent.documents.documents if self._doc_need_update(doc)],
[
doc
for doc in self.parent.documents.documents
if self._doc_need_update(doc)
and (
doc.opened_in_editor
or self.get_diagnostics_mode(doc.uri) == DiagnosticsMode.WORKSPACE
)
],
key=lambda d: not d.opened_in_editor,
)

Expand Down Expand Up @@ -436,7 +444,7 @@ def run_workspace_diagnostics(self) -> None:
documents_to_collect = [
doc
for doc in documents
if doc.opened_in_editor or self.get_diagnostics_mode(document.uri) == DiagnosticsMode.WORKSPACE
if doc.opened_in_editor or self.get_diagnostics_mode(doc.uri) == DiagnosticsMode.WORKSPACE
]

with self._logger.measure_time(
Expand Down
10 changes: 10 additions & 0 deletions ...ges/language_server/src/robotcode/language_server/robotframework/parts/robot_workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,16 @@ def load_workspace_documents(self, sender: Any) -> None:
for folder in self.parent.workspace.workspace_folders:
config = self.parent.workspace.get_configuration(RobotCodeConfig, folder.uri)

if config.analysis.diagnostic_mode != DiagnosticsMode.WORKSPACE:
self._logger.debug(
lambda: (
f"Skip loading workspace documents for {folder.uri.to_path()} "
f"because analysis.diagnosticMode={config.analysis.diagnostic_mode.value!r}"
),
context_name="load_workspace_documents",
)
continue

extensions = [ROBOT_FILE_EXTENSION, RESOURCE_FILE_EXTENSION]

exclude_patterns = [
Expand Down