Merge branch 'master' into feature/drag-and-drop-to-frame

Author: emanlove

.flake8

@@ -0,0 +1 @@
+*.approved.txt text eol=lf

.gitattributes

@@ -9,20 +9,20 @@ jobs:
     continue-on-error: true
     strategy:
       matrix:
-        python-version: [3.9.23, 3.13.5, 3.14.0-rc.3]  # pypy-3.9
-        # python-version: [{earliest: 3.9}, {latest: 3.13.0}]  # pypy-3.9
-        rf-version: [6.1.1, 7.3.2]
-        selenium-version: [4.28.1, 4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0, 4.34.2]
+        python-version: [3.10.16, 3.13.5, 3.14.4, pypy-3.10]
+        # python-version: [{earliest: 3.10}, {latest: 3.14.0-rc.3}, {pypy: pypy-3.10}]
+        rf-version: [6.1.1, 7.4.2]
+        selenium-version: [4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0, 4.34.2, 4.43.0]
         browser: [chrome]  # firefox, chrome, headlesschrome, edge
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Set up Python ${{ matrix.python-version }} with Robot Framework ${{ matrix.rf-version }}
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
     - name: Setup Chrome
-      uses: browser-actions/setup-chrome@v1
+      uses: browser-actions/setup-chrome@v2
       with:
         chrome-version: 138
         install-dependencies: true
@@ -44,12 +44,12 @@ jobs:
         export DISPLAY=:99.0
         Xvfb -ac :99 -screen 0 1280x1024x16 > /dev/null 2>&1 &
     - name: Install dependencies
-      if: matrix.python-version != 'pypy-3.7'
+      if: matrix.python-version != 'pypy-3.10'
       run: |
         python -m pip install --upgrade pip
         pip install -r requirements-dev.txt
     - name: Install dependencies for pypy
-      if: matrix.python-version == 'pypy-3.9'
+      if: matrix.python-version == 'pypy-3.10'
       run: |
         python -m pip install --upgrade pip
         pip install -r requirements.txt
@@ -68,7 +68,7 @@ jobs:
         echo "WEBDRIVERPATH=$($SELENIUM_MANAGER_EXE --browser chrome --debug | awk '/INFO[[:space:]]Driver path:/ {print $NF;exit}')" >> "$GITHUB_ENV"
         echo "$WEBDRIVERPATH"
     - name: Generate stub file for ${{ matrix.python-version }}
-      if: matrix.python-version != 'pypy-3.9'
+      if: matrix.python-version != 'pypy-3.10'
       run: |
         invoke gen-stub
 
@@ -84,20 +84,20 @@ jobs:
     #     xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }}
 
     - name: Run tests with latest python and latest robot framework
-      if: matrix.python-version == '3.13.0' && matrix.rf-version == '7.2.2'
+      if: matrix.python-version == '3.14.4' && matrix.rf-version == '7.4.1'
       run: |
         xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }}
 
     # - name: Run tests with Selenium Grid
-    #   if: matrix.python-version == '3.11' && matrix.rf-version == '3.2.2' && matrix.python-version != 'pypy-3.9'
+    #   if: matrix.python-version == '3.11' && matrix.rf-version == '3.2.2' && matrix.python-version != 'pypy-3.10'
     #   run: |
     #     wget --no-verbose --output-document=./selenium-server-standalone.jar http://selenium-release.storage.googleapis.com/3.141/selenium-server-standalone-3.141.59.jar
     #     sudo chmod u+x ./selenium-server-standalone.jar
     #     xvfb-run --auto-servernum python atest/run.py --zip headlesschrome  --grid True
 
-    - uses: actions/upload-artifact@v4
+    - uses: actions/upload-artifact@v7
       if: failure()
       with:
         name: sl_$${{ matrix.python-version }}_$${{ matrix.rf-version }}_$${{ matrix.selenium-version }}_$${{ matrix.browser }}
         path: atest/zip_results
-        overwrite: true
+        overwrite: true

.github/workflows/CI.yml

@@ -10,9 +10,9 @@ jobs:
       matrix:
         config:
           - description: latest
-            python-version: 3.13.10
-            rf-version: 7.4.1
-            selenium-version:  4.39.0
+            python-version: 3.14.4
+            rf-version: 7.4.2
+            selenium-version:  4.43.0
             browser: chrome
           - description: previous
             python-version: 3.12.12
@@ -24,19 +24,23 @@ jobs:
             rf-version: 6.1.1
             selenium-version: 4.37.0
             browser: chrome
-
+          - description: latest
+            python-version: 3.14.4
+            rf-version: 7.4.1
+            selenium-version: 4.39.0
+            browser: firefox
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
     - name: Configuration Description
       run: |
         echo "${{ matrix.config.description }} configuration"
         echo "Testing with RF v${{ matrix.config.rf-version }}, Selenium v${{ matrix.config.selenium-version}}, Python v${{ matrix.config.python-version }} under ${{ matrix.config.browser }}"
     - name: Set up Python ${{ matrix.config.python-version }}
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.config.python-version }}
     - name: Setup ${{ matrix.config.browser }} browser
-      uses: browser-actions/setup-chrome@v1
+      uses: browser-actions/setup-chrome@v2
       with:
         chrome-version: latest
         install-dependencies: true
@@ -71,9 +75,45 @@ jobs:
       run: |
         xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.config.browser }}
 
-    - uses: actions/upload-artifact@v4
+    - uses: actions/upload-artifact@v7
       if: failure()
       with:
-        name: sl_$${{ matrix.config.python-version }}_$${{ matrix.config.rf-version }}_$${{ matrix.config.selenium-version }}_$${{ matrix.config.browser }}
+        name: sl_${{ matrix.config.python-version }}_${{ matrix.config.rf-version }}_${{ matrix.config.selenium-version }}_${{ matrix.config.browser }}
         path: atest/zip_results
-        overwrite: true
+        overwrite: true
+  ruff:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v6
+
+    - name: Set up Python
+      uses: actions/setup-python@v6
+      with:
+        python-version: "3.14.4"
+
+    - name: Install dev dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install -r requirements-dev.txt
+
+    - name: Ruff format check
+      id: format
+      continue-on-error: true
+      run: |
+        python -m invoke formatter --check
+
+    - name: Ruff lint
+      id: lint
+      continue-on-error: true
+      run: |
+        python -m invoke lint
+
+    - name: Fail if any Ruff step failed
+      if: always()
+      run: |
+        echo "format outcome: ${{ steps.format.outcome }}"
+        echo "lint outcome:   ${{ steps.lint.outcome }}"
+        if [ "${{ steps.format.outcome }}" != "success" ] || [ "${{ steps.lint.outcome }}" != "success" ]; then
+          exit 1
+        fi

.github/workflows/Select.yml

@@ -118,21 +118,23 @@ needed in internal code. When docstrings are added, they should follow
 `PEP-257`_. See `Documentation`_ section below for more details about
 documentation syntax, generating docs, etc.
 
-The code should be formatted with `Black`_ and errors found by `flake8`_
-should be fixed. Black and flake8 can be run by using
-command::
+The code should be formatted and linted with `Ruff`_. See Development commands below for more details.
 
-    inv lint
+Development commands
+~~~~~~~~~~~~~~~~~~~~
 
-By default flake8 ignores line length error E501, but it does not ignore
-warning W503. In practice Black formats list access like this::
+Use `invoke`_ tasks for common local checks and test runs::
 
-    list[1 : 2]
+    inv formatter --check    # Check formatting with Ruff
+    inv formatter            # Format source files with Ruff
+    inv lint                 # Run Ruff lint checks
+    inv lint --fix           # Apply safe Ruff lint fixes
+    inv utest                # Run unit tests
+    inv atest                # Run acceptance tests (headlesschrome)
 
-But flake8 will display an warning about it. This should be manually
-fixed to look like::
-
-    list[1:2]
+Run these before opening a pull request so local results are close to CI.
+Use the project virtual environment and pinned dependencies from
+``requirements-dev.txt`` for consistent results across local runs and CI.
 
 Documentation
 -------------
@@ -160,7 +162,7 @@ individual keywords.
 
 Keyword documentation can be easily created using `invoke`_ task::
 
-    inv keyword_documentation
+    inv kw-docs
 
 Resulting docs should be verified before the code is committed.
 
@@ -245,5 +247,4 @@ the same code as your changes. In that case you should
 .. _utest/README.rst: https://github.com/robotframework/SeleniumLibrary/blob/master/utest/README.rst
 .. _sync your fork: https://help.github.com/articles/syncing-a-fork/
 .. _resolve conflicts: https://help.github.com/articles/resolving-a-merge-conflict-from-the-command-line
-.. _Black: https://github.com/psf/black
-.. _flake8: https://github.com/PyCQA/flake8
+.. _Ruff: https://github.com/astral-sh/ruff

CONTRIBUTING.rst

@@ -10,7 +10,7 @@ SeleniumLibrary_ is a web testing library for `Robot Framework`_ that
 utilizes the Selenium_ tool internally. The project is hosted on GitHub_
 and downloads can be found from PyPI_.
 
-SeleniumLibrary currently works with Selenium 4. It supports Python 3.8 through 3.13.
+SeleniumLibrary currently works with Selenium 4. It supports Python 3.10 through 3.13.
 In addition to the normal Python_ interpreter, it works also
 with PyPy_.
 

README.rst

@@ -121,7 +121,12 @@ def create_driver(
         )
 
     def create_seleniumwire(
-        self, desired_capabilities, remote_url, options=None, service_log_path=None, service=None,
+        self,
+        desired_capabilities,
+        remote_url,
+        options=None,
+        service_log_path=None,
+        service=None,
     ):
         logger.info(self.extra_dictionary)
         return webdriver.Chrome()

atest/acceptance/1-plugin/OpenBrowserExample.py

@@ -10,7 +10,7 @@ ${event_firing_or_none}     ${NONE}
 
 *** Test Cases ***
 Open Browser To Start Page
-    [Tags]    NoGrid
+    [Tags]    NoGrid    SKIP_ON_WINDOWS
     [Documentation]
     ...    LOG 1:30 DEBUG  Wrapping driver to event_firing_webdriver.
     ...    LOG 1:32 INFO  Got driver also from SeleniumLibrary.

atest/acceptance/2-event_firing_webdriver/event_firing_webdriver.robot

@@ -8,7 +8,7 @@ Create Webdriver Creates Functioning WebDriver
     [Documentation]
     ...    LOG 1:1 INFO REGEXP: Creating an instance of the \\w+ WebDriver.
     ...    LOG 1:18 DEBUG REGEXP: Created \\w+ WebDriver instance with session id (\\w|-)+.
-    [Tags]    Known Issue Internet Explorer    Known Issue Safari
+    [Tags]    Known Issue Internet Explorer    Known Issue Safari    SKIP_ON_WINDOWS
     [Setup]    Set Driver Variables
     Create Webdriver    ${DRIVER_NAME}    kwargs=${KWARGS}
     Go To    ${FRONT_PAGE}

atest/acceptance/create_webdriver.robot

@@ -7,7 +7,7 @@ Entry Point Version
     ${process} =    Run Process
     ...    python -m SeleniumLibrary.entry --version
     ...    shell=True
-    ...    cwd=${EXECDIR}/src
+    ...    cwd=${EXECDIR}${/}src
     Log    ${process.stdout}
     Log    ${process.stderr}
     Should Be Equal As Integers    ${process.rc}    0
@@ -17,18 +17,18 @@ Entry Point Version
 
 Entry Point Translation
     ${process} =    Run Process
-    ...    python -m SeleniumLibrary.entry translation ${OUTPUT_DIR}/translation.json
+    ...    python -m SeleniumLibrary.entry translation ${OUTPUT_DIR}${/}translation.json
     ...    shell=True
-    ...    cwd=${EXECDIR}/src
+    ...    cwd=${EXECDIR}${/}src
     Log    ${process.stdout}
     Log    ${process.stderr}
     Should Be Equal As Integers    ${process.rc}    0
     Should Be Empty    ${process.stderr}
-    Should Be Equal    ${process.stdout}    Translation file created in ${OUTPUT_DIR}/translation.json
+    Should Be Equal    ${process.stdout}    Translation file created in ${OUTPUT_DIR}${/}translation.json
     ${process} =    Run Process
-    ...    python -m SeleniumLibrary.entry translation --compare ${OUTPUT_DIR}/translation.json
+    ...    python -m SeleniumLibrary.entry translation --compare ${OUTPUT_DIR}${/}translation.json
     ...    shell=True
-    ...    cwd=${EXECDIR}/src
+    ...    cwd=${EXECDIR}${/}src
     Log    ${process.stdout}
     Log    ${process.stderr}
     Should Be Equal As Integers    ${process.rc}    0