Masquerade bugfix + Allow masquerade in the node/watchtower loops. #1120
Open
thomaspanf wants to merge 6 commits into
Open
Masquerade bugfix + Allow masquerade in the node/watchtower loops. #1120thomaspanf wants to merge 6 commits into
thomaspanf wants to merge 6 commits into
Conversation
…d prompting to wallet masquerade and wallet status commands when observing
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Masquerade broke when we switched to a long-standing HTTP API process. The real node address is cached once and returned by the API every time the CLI called
GetWallet. Previouslyrocketpool_api(now deprecated) would make a fresh read of masquerade address from disk every time the CLI called it. This PR resolves the issue by ensuringGetWalletreturns the correct masquerade state and address when called from the CLI.Added flag
--observeto thewallet masqueradecommand. When this flag is passed, the node/watchtower loop will use the masqueraded address for all tasks except formanageFeeRecipient. Transactions cannot be submitted and oDAO nodes are blocked from using the flag.