Remove misleading RuboCop comment in gemspec#403
Open
tagliala wants to merge 1 commit into
Open
Conversation
The comment claimed Ruby 2.5 was the oldest syntax supported by RuboCop, but this was only true briefly in RuboCop 1.28 (Apr 2022) when runtime and code analysis support were accidentally dropped together. RuboCop quickly restored code analysis support: - PR rubocop/rubocop#10626 (May 12 2022 v1.29.1) restored TargetRubyVersion 2.5 - PR rubocop/rubocop#10668 (May 25 2022) restored TargetRubyVersion 2.0 RuboCop now supports analyzing Ruby 2.0+ code, so the comment is misleading and should be removed. The gem's minimum Ruby version is a project-level decision best guided by its own compatibility goals rather than by the support matrix of any single development tool. With Ruby 3.2 being the current minimum non-EOL release, >= 2.5 already offers generous backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment claimed Ruby 2.5 was the oldest syntax supported by RuboCop, but this was only true briefly in RuboCop 1.28 (Apr 2022) when runtime and code analysis support were accidentally dropped together.
RuboCop quickly restored code analysis support:
TargetRubyVersion: 2.5rubocop/rubocop#10626 (May 12 2022 v1.29.1) restored TargetRubyVersion 2.5TargetRubyVersion: 2.0rubocop/rubocop#10668 (May 25 2022) restored TargetRubyVersion 2.0RuboCop now supports analyzing Ruby 2.0+ code, so the comment is misleading and should be removed.
The gem's minimum Ruby version is a project-level decision best guided by its own compatibility goals rather than by the support matrix of any single development tool. With Ruby 3.2 being the current minimum non-EOL release, >= 2.5 already offers generous backward compatibility.