Fix preset.sh returning invalid http response#219
Open
mcarbonne wants to merge 1 commit into
Open
Conversation
Author
|
@roleoroleo the fix has been running for a few days without any issues on my setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a recent update of the firmware on my camera, I had a lot of error logs in my home assistant instance :
To reproduce the issue without home assistant :
I found the culprit. For whatever reason, ptz binary do output something on stdout so I redirected the output to
/dev/null.I also fixed a bash syntax error in the same file.
Maybe having
shellcheckrunning in a github action would be a good idea, I can open another PR regarding this point (but this PR focuses on fixing the bug only)