Skip to content

fix(logback): restrict recursive logger suppression to Rollbar package#376

Open
Montana wants to merge 4 commits into
rollbar:masterfrom
Montana:patch-1
Open

fix(logback): restrict recursive logger suppression to Rollbar package#376
Montana wants to merge 4 commits into
rollbar:masterfrom
Montana:patch-1

Conversation

@Montana

@Montana Montana commented Jun 5, 2026

Copy link
Copy Markdown

Only suppress events emitted by the com.rollbar logger or one of its package descendants.

The previous recursive logging check used a broad prefix match against com.rollbar. As a result, unrelated application loggers with names that happened to begin with the same characters were incorrectly treated as internal Rollbar loggers and silently skipped. For example, a logger such as com.rollbarista.checkout would never be forwarded to Rollbar even though it is not part of the Rollbar package.

So this updates the check so it only matches the exact com.rollbar logger or names beginning with the com.rollbar. package boundary. This preserves the recursive logging protection for Rollbar’s own internal logs while allowing similarly named application packages to be reported normally.

@Montana Montana left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up the implementation and removed the accidental extra formatting changes so the final diff is focused only on the recursive logger suppression fix.

The branch now includes a few incremental cleanup commits from editing through the GitHub interface, but the resulting code is in the intended state. The maintainer can squash the commits during merge to keep the history clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant