[minicern] fix rank mismatches in hbook#22623
Draft
ferdymercury wants to merge 1 commit into
Draft
Conversation
Test Results 20 files 20 suites 3d 11h 33m 51s ⏱️ For more details on these failures, see this check. Results for commit 3825269. ♻️ This comment has been updated with latest results. |
Warnings are turned off at the moment, if you turn on, one sees many rank-mismatch warnings. To verify, remove these lines in misc/minicern/CMakeLists.txt -# Disable warnings, since what has worked for 40 years... -# (see https://sft.its.cern.ch/jira/browse/ROOT-9179 for the warnings) -set_target_properties(minicern PROPERTIES COMPILE_FLAGS "-w")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warnings are turned off at the moment, if you turn on, one sees many rank-mismatch warnings. To verify, remove these lines in misc/minicern/CMakeLists.txt
We don't turn them on here because there still many to fix in zebra.f