Allow eval substitutions with spaced expressions#981
Open
dlanov wants to merge 1 commit into
Open
Conversation
Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows
evalsubstitutions to parse expressions that the frontend splits across multiple arguments because of spaces.For example,
$(eval 1 == 1)can now be parsed by joining the split expression arguments back together with spaces.Changes
PythonExpression.parse()to accept three or more expression arguments.Testing
python -m pytest launch/test/launch/substitutions/test_python_expression.py -qpython -m pytest launch/test/launch/frontend/test_substitutions.py -qpython -m flake8 --ignore=E501 launch/launch/substitutions/python_expression.py launch/test/launch/substitutions/test_python_expression.pygit diff --checkIssue reference
Relates #469
Notes
This keeps the existing one-argument and two-argument parsing behavior unchanged.
In particular, this PR does not change the existing handling of unescaped quote characters in frontend expressions.
AI assistance disclosure
Claude Code helped prepare this code change and test.
I manually reviewed the diff and test results.