[wjwwood] Updated "Data race fixes"#2500
Merged
Merged
Conversation
Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Before this change, the rebuild of wait set would be triggered after the wait set was waken up. With bad timing, this could lead to the rebuild not happening with multi threaded executor. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Janosch Machowinski <j.machowinski@nospam.org>
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Signed-off-by: William Woodall <william@osrfoundation.org>
Closed
jmachowinski
approved these changes
Apr 12, 2024
Member
Author
|
Fixed the conflicts due to other merges, @jmachowinski can you have a look at also, copying from #2494 (comment): On my machine, the test I'll run CI just to confirm:
I wasn't able to see any obvious issue, the CI is with my changes in #2500, but locally even this pr's changes have that problem. |
Collaborator
|
I'll look into it |
added 3 commits
April 12, 2024 10:09
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
…g for current_notify_waitable_ Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Member
|
alsora
approved these changes
Apr 12, 2024
Member
Author
|
lgtm |
bartalor
pushed a commit
to bartalor/rclcpp
that referenced
this pull request
Jul 15, 2026
* Fix callback group logic in executor Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com> * fix: Fixed unnecessary copy of wait_set Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * fix(executor): Fixed race conditions with rebuild of wait_sets Before this change, the rebuild of wait set would be triggered after the wait set was waken up. With bad timing, this could lead to the rebuild not happening with multi threaded executor. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * fix(Executor): Fixed lost of entities rebuild request Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com> * chore: Added assert for not set callback_group in execute_any_executable Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * Add test for cbg getting reset Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Janosch Machowinski <j.machowinski@nospam.org> * chore: renamed test cases to snake_case Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * style Signed-off-by: William Woodall <william@osrfoundation.org> * fixup test to avoid polling and short timeouts Signed-off-by: William Woodall <william@osrfoundation.org> * fix: Use correct notify_waitable_ instance Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * fix(StaticSingleThreadedExecutor): Added missing special case handling for current_notify_waitable_ Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> * fix(TestCallbackGroup): Fixed test after change to timers Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> --------- Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com> Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: William Woodall <william@osrfoundation.org> Co-authored-by: Janosch Machowinski <j.machowinski@cellumation.com> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Janosch Machowinski <j.machowinski@nospam.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #2494
Which I could not update.