Fix glibc detection#575
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
The existing probe treats any libc with backtrace() as glibc and propagates the result variable name instead of its value. Check the glibc identification macro and return the actual compiler test result to the caller. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__GLIBC__identification macro instead of treating the non-uniquebacktrace()API as a proxy.check_c_source_compiles()result to the caller rather than the result variable's name.Closes #574.
Why
Other C libraries can provide a compatible
backtrace()implementation, so compiling that call does not prove that the compiler targets glibc. Additionally, the existingPARENT_SCOPEassignment stores the literal result variable name, preventing the caller from receiving the boolean compiler-test result.Testing
parent='<RESULT_VARIABLE>', including the non-glibc case.parent='1', cache='1'; the non-glibc case reportsparent='', cache=''.cmake -P.git diff origin/rolling...HEAD --check