feat: Allow types to be imported from the other projects#23
Open
xeho91 wants to merge 3 commits into
Open
Conversation
roydukkey
changed the title
roydukkey
requested changes
Jan 20, 2023
| "noImplicitThis": true, | ||
| "removeComments": false | ||
| "removeComments": false, | ||
| "isolatedModules": true |
Owner
There was a problem hiding this comment.
What issue where you hitting here? I think it makes sense, but would like to here your thoughts too.
| // Licensed under the MIT. See LICENSE file in the project root for full license information. | ||
|
|
||
|
|
||
| export * from "./spec"; |
Owner
There was a problem hiding this comment.
Suggested change
| export * from "./spec"; | |
| export type { CompiledConfig, Config, JsonDocument } from "./spec"; |
Some of these types have no relevance with the other exports of this file. For example, types that support the CLI.
Likewise, some of the others are internals and I'd like to avoid making them public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
It resolves the issue where the types defined in your project cannot be imported.
I noticed it when trying to make an extendable config for my projects.
For example, once you try:
there's an error message:
By the way, thank you for this great tool! ❤️