Skip to content

[codex] Harden route transforms and dev lifecycle#46

Merged
ScriptedAlchemy merged 4 commits into
perf/bundling-performancefrom
codex/harden-route-transforms-dev-lifecycle
Jun 22, 2026
Merged

[codex] Harden route transforms and dev lifecycle#46
ScriptedAlchemy merged 4 commits into
perf/bundling-performancefrom
codex/harden-route-transforms-dev-lifecycle

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator

Summary

  • harden route export pruning and component wrapping for PR Add React Router plugin performance optimizations #39, including TypeScript runtime syntax, comments, named default classes, source re-exports, type exports, and lowercase JSX member imports
  • isolate parallel route transform worker state by task/environment, cap/gate worker usage, and close pending work explicitly
  • fix manifest emit error propagation, production source map handling, prerender default concurrency, and route topology watcher lifecycle coverage

Context

Stacked on #39 (perf/bundling-performance) in response to Matthew Davis's review notes and patch. I also cloned and indexed remix-run/react-router under /home/zack/projects/react-router; TraceDecay located the comparable Vite implementation at packages/react-router-dev/vite/remove-exports.ts, which I used as the main parity reference.

Validation

  • git apply --check /home/zack/Downloads/0001-fix-harden-route-transforms-and-dev-lifecycle.patch
  • pnpm test:core
  • pnpm build
  • pnpm format:check
  • git diff --check HEAD^..HEAD
  • pnpm --filter default-template test:e2e -- dev-route-watch.test.ts

Notes

This is still a large corrective patch. It addresses the concrete P1 regressions from the review, but it does not fully split #39 into the longer ideal stack described in the review file.

@ScriptedAlchemy ScriptedAlchemy changed the base branch from perf/bundling-performance to main June 22, 2026 20:56
@pkg-pr-new

pkg-pr-new Bot commented Jun 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/rsbuild-plugin-react-router@933962d

commit: 933962d

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results

Compared PR head 933962d against base 06ae3db.

Total median wall time: 20.35s -> 9.40s (-53.8%, 2.16x speedup)

Benchmark Base Head Delta Speedup Head RSS p95
synthetic-256-sourcemaps 3.59s 2.31s -35.7% 1.56x 413 MB
synthetic-256-spa 8.46s 2.25s -73.4% 3.76x 401 MB
synthetic-256-ssr-esm 3.59s 2.21s -38.6% 1.63x 398 MB
synthetic-256-ssr-esm-split 4.70s 2.64s -43.9% 1.78x 412 MB

Profile: default; iterations: 5; warmup: 1.
Workflow run

@ScriptedAlchemy ScriptedAlchemy changed the base branch from main to perf/bundling-performance June 22, 2026 21:01
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/harden-route-transforms-dev-lifecycle branch from 933962d to 51188f0 Compare June 22, 2026 21:01
@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review June 22, 2026 22:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51188f0c14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.ts Outdated
@ScriptedAlchemy ScriptedAlchemy merged commit 79301f4 into perf/bundling-performance Jun 22, 2026
@ScriptedAlchemy ScriptedAlchemy deleted the codex/harden-route-transforms-dev-lifecycle branch June 22, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants