[codex] Harden route transforms and dev lifecycle#46
Merged
ScriptedAlchemy merged 4 commits intoJun 22, 2026
Merged
Conversation
commit: |
Contributor
Benchmark ResultsCompared PR head Total median wall time: 20.35s -> 9.40s (-53.8%, 2.16x speedup)
Profile: |
933962d to
51188f0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51188f0c14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Stacked on #39 (
perf/bundling-performance) in response to Matthew Davis's review notes and patch. I also cloned and indexedremix-run/react-routerunder/home/zack/projects/react-router; TraceDecay located the comparable Vite implementation atpackages/react-router-dev/vite/remove-exports.ts, which I used as the main parity reference.Validation
git apply --check /home/zack/Downloads/0001-fix-harden-route-transforms-and-dev-lifecycle.patchpnpm test:corepnpm buildpnpm format:checkgit diff --check HEAD^..HEADpnpm --filter default-template test:e2e -- dev-route-watch.test.tsNotes
This is still a large corrective patch. It addresses the concrete P1 regressions from the review, but it does not fully split #39 into the longer ideal stack described in the review file.