Skip to content

fix: watch React Router config dependencies#56

Draft
ScriptedAlchemy wants to merge 2 commits into
perf/bundling-performancefrom
codex/config-dependency-watch
Draft

fix: watch React Router config dependencies#56
ScriptedAlchemy wants to merge 2 commits into
perf/bundling-performancefrom
codex/config-dependency-watch

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator

Summary

  • watch relative files imported by react-router.config.* so dev server config helper changes reload the server
  • accept stable React Router config fields for splitRouteModules, subResourceIntegrity, and prerender.concurrency while preserving old aliases where needed
  • add focused tests for config dependency discovery, SRI, and prerender concurrency

Validation

  • pnpm test:core
  • pnpm build
  • git diff --check

Notes

This is stacked on PR #39 (perf/bundling-performance). TraceDecay MCP discovery was unavailable in this thread and the local TraceDecay store returned stale/hanging/malformed-status results, so the implementation was verified with targeted source comparison against React Router plus executable tests.

@ScriptedAlchemy ScriptedAlchemy force-pushed the perf/bundling-performance branch from 95bc09e to 470c3c8 Compare June 27, 2026 02:38
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/config-dependency-watch branch from 8772c70 to b0a7155 Compare June 27, 2026 06:06
@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Compared PR head 62a5061 against base 470c3c8.

Total median wall time: 9.80s -> 9.37s (-4.4%, 1.05x speedup)
Compiler ready median: 8.11s -> 7.83s (-3.5%)
Route load median: 1.53s -> 1.48s (-3.2%)

Benchmark Base total Head total Delta Head ready Head routes Speedup Head RSS p95
large-355-ssr-esm 9.80s 9.37s -4.4% 7.83s 1.48s 1.05x -

Profile: large; mode: dev; iterations: 3; warmup: 0.
Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant