Skip to content

fix: reload on route manifest metadata changes#58

Draft
ScriptedAlchemy wants to merge 2 commits into
codex/asset-query-parityfrom
codex/route-dev-reload-parity
Draft

fix: reload on route manifest metadata changes#58
ScriptedAlchemy wants to merge 2 commits into
codex/asset-query-parityfrom
codex/route-dev-reload-parity

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator

Summary

  • detect dev route manifest metadata changes such as loader/clientLoader/export flag changes
  • trigger a full browser reload for those changes instead of relying on a React Router Vite-only route HMR runtime
  • add runtime and controller tests proving the reload path

Validation

  • pnpm test:core
  • pnpm build
  • git diff --check

Notes

Stacked on codex/asset-query-parity. This intentionally chooses the conservative full-reload fallback because the Rsbuild plugin does not currently ship React Router's Vite route-HMR runtime.

@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/asset-query-parity branch from 1f2dcfd to 88aa4ec Compare June 27, 2026 06:06
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/route-dev-reload-parity branch from 7e75bfb to a38d779 Compare June 27, 2026 06:06
@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Compared PR head 6ab91d0 against base 8b08bd7.

Total median wall time: 11.89s -> 11.96s (+0.6%, 0.99x speedup)
Compiler ready median: 9.82s -> 9.81s (-0.1%)
Route load median: 2.03s -> 2.11s (+4.0%)

Benchmark Base total Head total Delta Head ready Head routes Speedup Head RSS p95
large-355-ssr-esm 11.89s 11.96s +0.6% 9.81s 2.11s 0.99x -

Profile: large; mode: dev; iterations: 3; warmup: 0.
Workflow run

@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/asset-query-parity branch from 88aa4ec to 8b08bd7 Compare June 28, 2026 19:58
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/route-dev-reload-parity branch from a38d779 to 6ab91d0 Compare June 28, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant