test: cover dynamic CSS parity#59
Draft
ScriptedAlchemy wants to merge 1 commit into
Draft
Conversation
7e75bfb to
a38d779
Compare
d377ac5 to
fd4d7c3
Compare
Contributor
Benchmark ResultsCompared PR head Total median wall time: 12.35s -> 12.13s (-1.8%, 1.02x speedup)
Profile: |
fd4d7c3 to
4e6d0f8
Compare
a38d779 to
6ab91d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm buildpnpm test:corecd examples/default-template && pnpm exec playwright test -g "keeps route CSS applied when the same CSS is dynamically imported"git diff --checkNotes
Stacked on
codex/route-dev-reload-parity. I did not addunstable_setDevServerHooksfor critical CSS because Rsbuild extracts CSS files by default and the dynamic CSS e2e passes without it. I also did not add request-error stack trace hook code because no failing repro was established.