Skip to content

test: cover dynamic CSS parity#59

Draft
ScriptedAlchemy wants to merge 1 commit into
codex/route-dev-reload-parityfrom
codex/dynamic-css-dev-hooks
Draft

test: cover dynamic CSS parity#59
ScriptedAlchemy wants to merge 1 commit into
codex/route-dev-reload-parityfrom
codex/dynamic-css-dev-hooks

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Collaborator

Summary

  • add e2e coverage for the dynamic CSS ownership scenario from the React Router Vite parity audit
  • verify that Rsbuild/Rspack keeps route CSS applied when the same CSS is dynamically imported later
  • intentionally adds no plugin runtime hook because the scenario passes with Rsbuild/Rspack CSS handling

Validation

  • pnpm build
  • pnpm test:core
  • cd examples/default-template && pnpm exec playwright test -g "keeps route CSS applied when the same CSS is dynamically imported"
  • git diff --check

Notes

Stacked on codex/route-dev-reload-parity. I did not add unstable_setDevServerHooks for critical CSS because Rsbuild extracts CSS files by default and the dynamic CSS e2e passes without it. I also did not add request-error stack trace hook code because no failing repro was established.

@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/route-dev-reload-parity branch from 7e75bfb to a38d779 Compare June 27, 2026 06:06
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/dynamic-css-dev-hooks branch from d377ac5 to fd4d7c3 Compare June 27, 2026 06:06
@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Compared PR head 4e6d0f8 against base 6ab91d0.

Total median wall time: 12.35s -> 12.13s (-1.8%, 1.02x speedup)
Compiler ready median: 10.17s -> 9.92s (-2.4%)
Route load median: 2.10s -> 2.14s (+1.7%)

Benchmark Base total Head total Delta Head ready Head routes Speedup Head RSS p95
large-355-ssr-esm 12.35s 12.13s -1.8% 9.92s 2.14s 1.02x -

Profile: large; mode: dev; iterations: 3; warmup: 0.
Workflow run

@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/dynamic-css-dev-hooks branch from fd4d7c3 to 4e6d0f8 Compare June 28, 2026 19:58
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/route-dev-reload-parity branch from a38d779 to 6ab91d0 Compare June 28, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant