Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,12 @@ export const pluginReactRouter = (
});
});

if (!isBuild) {
api.onAfterCreateCompiler(() => {
routeTransformExecutor.prewarm();
});
}

api.onCloseDevServer(async () => {
await closeRouteTopologyWatcher?.();
closeRouteTopologyWatcher = undefined;
Expand Down
36 changes: 36 additions & 0 deletions src/parallel-route-transforms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export type RouteTransformExecutorOptions = RouteTransformTaskOptions & {

export type RouteTransformExecutor = {
run: (task: RouteTransformTask) => Promise<RouteTransformResult>;
prewarm: () => void;
close: () => Promise<void>;
};

Expand Down Expand Up @@ -121,6 +122,7 @@ class ParallelRouteTransformExecutor implements RouteTransformExecutor {
#nextSplitRouteAnalysisWorkerIndex = 0;
#splitRouteAnalysisWorkers = new Map<string, number>();
#workers: Array<WorkerState | undefined> | undefined;
#prewarmScheduled = false;

constructor(
private readonly workerCount: number,
Expand All @@ -147,6 +149,38 @@ class ParallelRouteTransformExecutor implements RouteTransformExecutor {
}
}

prewarm(): void {
if (this.#prewarmScheduled || this.#closed || this.#workersDisabled) {
return;
}
this.#prewarmScheduled = true;
void this.#prewarmWorkers();
}

async #prewarmWorkers(): Promise<void> {
try {
for (let index = 0; index < this.workerCount; index += 1) {
if (this.#closed || this.#workersDisabled) {
return;
}
try {
this.#getWorker(index);
} catch (error) {
const startupError = new WorkerStartupError(
error instanceof Error ? error.message : String(error)
);
if (error instanceof Error) {
startupError.stack = error.stack;
}
this.#disableWorkers(startupError);
return;
}
}
} finally {
this.#prewarmScheduled = false;
}
}

close(): Promise<void> {
if (this.#closePromise) {
return this.#closePromise;
Expand Down Expand Up @@ -353,6 +387,7 @@ const createRouteTransformExecutorWithWorkerFactory = (
if (parallelTransforms === false) {
return {
run: task => executeRouteTransformTask(task, options),
prewarm: () => {},
close: async () => {},
};
}
Expand All @@ -364,6 +399,7 @@ const createRouteTransformExecutorWithWorkerFactory = (
if (workerCount < 1) {
return {
run: task => executeRouteTransformTask(task, options),
prewarm: () => {},
close: async () => {},
};
}
Expand Down
26 changes: 26 additions & 0 deletions tests/parallel-route-transforms.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,32 @@ describe('parallel route transforms', () => {
expect(workers.map(worker => worker.terminateCalls)).toEqual([1, 1]);
});

it('can prewarm worker slots before the first route transform', async () => {
const workers: FakeRouteTransformWorker[] = [];
const executor = createRouteTransformExecutorForTesting(
{
parallelTransforms: 4,
},
() => {
const worker = new FakeRouteTransformWorker();
workers.push(worker);
return worker;
}
);

executor.prewarm();
executor.prewarm();
expect(workers).toHaveLength(4);

executor.prewarm();
expect(workers).toHaveLength(4);

await executor.close();
expect(workers.map(worker => worker.terminateCalls)).toEqual([
1, 1, 1, 1,
]);
});

it('executes route client entry tasks through the shared task executor', async () => {
await expect(
executeRouteTransformTask({
Expand Down
Loading