[codex] support React Router 8 compatibility#67
Draft
ScriptedAlchemy wants to merge 8 commits into
Draft
Conversation
Contributor
Benchmark ResultsCompared PR head Total median wall time: 9.79s -> 9.72s (-0.7%, 1.01x speedup)
Profile: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/react-router-8as a direct copy of React Router’sintegration/helpers/vite-8-template, with the Vite config/scripts swapped for this Rsbuild plugin.UNSAFE_*route wrapper helpers and aliasingreact-routerpackage imports to the app install.Validation
pnpm prettier --write package.json README.md src/index.ts src/plugin-utils.ts src/route-component-transform.ts tests/index.test.ts tests/plugin-utils.test.ts examples/react-router-8/package.json examples/react-router-8/README.md examples/react-router-8/app/root.tsx examples/react-router-8/app/routes.ts examples/react-router-8/app/routes/_index.tsx examples/react-router-8/env.d.ts examples/react-router-8/playwright.config.ts examples/react-router-8/react-router.config.ts examples/react-router-8/rsbuild.config.ts examples/react-router-8/tests/e2e/react-router-8.test.ts examples/react-router-8/tsconfig.jsonpnpm prettier --write package.json .changeset/react-router-8-default-template.mdgit diff --checkpnpm test:core -- tests/plugin-utils.test.ts tests/index.test.tspnpm test:core -- tests/plugin-utils.test.ts tests/index.test.ts tests/prerender.test.ts tests/react-router-config.test.ts tests/modify-browser-manifest.test.tspnpm --filter react-router-8-default-template typecheckpnpm buildpnpm --filter react-router-8-default-template test:e2epnpm test:package-interopTraceDecay was used for changed-file impact context; latest diff context mapped the plugin changes to route transform/dev runtime coverage and affected tests.
Note: this PR is stacked on
codex/prewarm-route-workersbecause the worktree started from that branch. Against that base, this branch contains the React Router 8 compatibility/example work.