Skip to content

chore: add Rslint#5

Merged
chenjiahan merged 1 commit intomasterfrom
chore/add-rslint
May 7, 2026
Merged

chore: add Rslint#5
chenjiahan merged 1 commit intomasterfrom
chore/add-rslint

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

This PR replaces the repository ESLint lint entrypoint with Rslint. It adds rslint.config.ts, the @rslint/core dev dependency, a VS Code extension recommendation, and a GitHub Actions lint workflow that runs pnpm run lint.

Breaking Changes

None.

Additional Info

Validated locally with pnpm run lint.

Copilot AI review requested due to automatic review settings May 7, 2026 13:27
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fda6355cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repository’s JavaScript linting setup from ESLint to Rslint, updating config, dependencies, editor recommendations, and CI to run the new linter.

Changes:

  • Added a new rslint.config.ts and updated package.json scripts to use rslint (with a --fix variant).
  • Removed ESLint-related configuration/dependencies and updated the lockfile accordingly.
  • Added VS Code extension recommendations and a GitHub Actions workflow to run pnpm run lint.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rslint.config.ts Introduces the Rslint configuration and test-file rule overrides.
package.json Switches lint scripts/deps from ESLint to Rslint and adds a fix script.
pnpm-lock.yaml Updates dependency graph for the new linter and removes ESLint packages.
.vscode/extensions.json Recommends the Rslint VS Code extension (and Prettier).
.gitignore Allows committing .vscode/extensions.json while ignoring other .vscode files.
.github/workflows/lint.yml Adds CI lint job running pnpm run lint.
.eslintrc.js Removes the ESLint configuration file.
.eslintignore Removes ESLint ignore patterns (now needs an equivalent for Rslint).
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rslint.config.ts
Comment thread package.json
Comment thread package.json
@chenjiahan chenjiahan merged commit 03018dc into master May 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants