chore: add Rslint#5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fda6355cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s JavaScript linting setup from ESLint to Rslint, updating config, dependencies, editor recommendations, and CI to run the new linter.
Changes:
- Added a new
rslint.config.tsand updatedpackage.jsonscripts to userslint(with a--fixvariant). - Removed ESLint-related configuration/dependencies and updated the lockfile accordingly.
- Added VS Code extension recommendations and a GitHub Actions workflow to run
pnpm run lint.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
rslint.config.ts |
Introduces the Rslint configuration and test-file rule overrides. |
package.json |
Switches lint scripts/deps from ESLint to Rslint and adds a fix script. |
pnpm-lock.yaml |
Updates dependency graph for the new linter and removes ESLint packages. |
.vscode/extensions.json |
Recommends the Rslint VS Code extension (and Prettier). |
.gitignore |
Allows committing .vscode/extensions.json while ignoring other .vscode files. |
.github/workflows/lint.yml |
Adds CI lint job running pnpm run lint. |
.eslintrc.js |
Removes the ESLint configuration file. |
.eslintignore |
Removes ESLint ignore patterns (now needs an equivalent for Rslint). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR contains a:
Motivation / Use-Case
This PR replaces the repository ESLint lint entrypoint with Rslint. It adds
rslint.config.ts, the@rslint/coredev dependency, a VS Code extension recommendation, and a GitHub Actions lint workflow that runspnpm run lint.Breaking Changes
None.
Additional Info
Validated locally with
pnpm run lint.