Consolidate CE + art supplies built-ins onto callout rows; drop legacy columns#1984
Draft
maebeale wants to merge 1 commit into
Draft
Consolidate CE + art supplies built-ins onto callout rows; drop legacy columns#1984maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
…y columns Every built-in callout page now renders its copy from the materialized callout row's "Callout page text" (CE, handouts, FAQ, scholarship previously dropped it). Move CE and art_supplies (formerly event_details) fully onto the row: drop the event-level ce_hours_details/_label and event_details/_label columns, delete the orphaned events#ce_hours and events#details pages, make art_supplies a content callout rendered on the generic callout page, and rename its magic_key. Refactor the scholarship/faq pages onto the shared callout-page layout. No data backfill. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 5 Inspect 🔬 migrations that drop Event columns + removal of two standalone pages + wide callout-system changes
What is the goal of this PR and why is this important?
event_details) built-ins fully onto their callout rows, so their content is edited in one place like every other built-in.How did you approach the change?
ce_hours_details/ce_hours_details_labelandevent_details/event_details_label(two reversible migrations, no backfill — the ticket system isn't in production use for these and dev data re-seeds).events#ce_hoursandevents#details(nothing linked to them; superseded by the callout pages).art_suppliesa content callout so it renders on the generic callout page, and rename itsmagic_keyevent_details→art_supplies(default title "Art supplies & what to bring")._callout_pagelayout (removes duplicated chrome).event_details_cardplumbing.Anything else to add?