Skip to content

Consolidate CE + art supplies built-ins onto callout rows; drop legacy columns#1984

Draft
maebeale wants to merge 1 commit into
mainfrom
maebeale/consolidate-ce-art-supplies-callouts
Draft

Consolidate CE + art supplies built-ins onto callout rows; drop legacy columns#1984
maebeale wants to merge 1 commit into
mainfrom
maebeale/consolidate-ce-art-supplies-callouts

Conversation

@maebeale

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 5 Inspect 🔬 migrations that drop Event columns + removal of two standalone pages + wide callout-system changes

What is the goal of this PR and why is this important?

  • Every built-in callout page now renders its intro copy from the materialized callout row's "Callout page text" (CE, handouts, FAQ, scholarship previously accepted the text but silently dropped it).
  • Finishes migrating the CE and "art supplies" (formerly event_details) built-ins fully onto their callout rows, so their content is edited in one place like every other built-in.

How did you approach the change?

  • Drop the legacy event-level columns ce_hours_details / ce_hours_details_label and event_details / event_details_label (two reversible migrations, no backfill — the ticket system isn't in production use for these and dev data re-seeds).
  • Delete the two orphaned standalone pages events#ce_hours and events#details (nothing linked to them; superseded by the callout pages).
  • Make art_supplies a content callout so it renders on the generic callout page, and rename its magic_key event_detailsart_supplies (default title "Art supplies & what to bring").
  • Refactor the scholarship and FAQ pages onto the shared _callout_page layout (removes duplicated chrome).
  • Remove the dead editor branch + event_details_card plumbing.

Anything else to add?

…y columns

Every built-in callout page now renders its copy from the materialized callout
row's "Callout page text" (CE, handouts, FAQ, scholarship previously dropped it).
Move CE and art_supplies (formerly event_details) fully onto the row: drop the
event-level ce_hours_details/_label and event_details/_label columns, delete the
orphaned events#ce_hours and events#details pages, make art_supplies a content
callout rendered on the generic callout page, and rename its magic_key. Refactor
the scholarship/faq pages onto the shared callout-page layout. No data backfill.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 14, 2026 20:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants