Skip to content

Remove the footer's inline script and SVG's inline style (CSP) #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maebeale wants to merge 3 commits into
base: main
Choose a base branch
from
+25 −18
Open

Remove the footer's inline script and SVG's inline style (CSP) #1985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b0a008
Remove the footer's inline script and svg's inline style (CSP)
maebeale Jul 14, 2026
4930cdc
Reuse the dropdown controller for the footer help button
maebeale Jul 15, 2026
a62e3d7
Add system spec covering the footer help button toggle
maebeale Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions app/views/shared/_footer_nav.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<!-- Floating Help Button -->
<div id="fab-container"
class="fixed bottom-6 right-6 z-50 flex flex-col items-end">
<div class="fixed bottom-6 right-6 z-50 flex flex-col items-end"
data-controller="dropdown">

<!-- Hidden menu items -->
<div id="fab-menu"
data-dropdown-target="content"
class="hidden flex flex-col items-start space-y-2 mb-2 p-4 bg-white border border-gray-300 rounded-lg shadow-md transition-all duration-300">

<%= link_to faqs_path, class: "flex items-center space-x-2 text-gray-800 px-3 py-2 rounded hover:bg-gray-100 w-max" do %>
Expand Down Expand Up @@ -33,23 +34,10 @@
<!-- Main round button -->
<button id="fab-button"
type="button"
data-action="dropdown#toggle"
data-dropdown-payload-param='[{"fab-menu":"hidden"}, {"fab-button":"rotate-45"}]'

@maebeale maebeale Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 From Claude: Reusing dropdown's payload API instead of a bespoke controller: each object maps an element id to the class(es) to toggle — hidden on the menu, rotate-45 on the button. Same pattern as the accordion callers.

class="bg-primary text-white w-10 h-10 rounded-full shadow-lg flex items-center
justify-center text-lg font-bold hover:bg-blue-700 transition">
?
</button>
</div>

<script>
document.addEventListener("turbo:load", () => {
const fabButton = document.getElementById("fab-button");
const fabMenu = document.getElementById("fab-menu");

if (!fabButton || !fabMenu) return;

// Remove any previous event listener to prevent duplicates
fabButton.onclick = () => {
fabMenu.classList.toggle("hidden");
fabButton.classList.toggle("rotate-45");
};
});
</script>
2 changes: 1 addition & 1 deletion app/views/shared/_svg_symbols.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<svg xmlns="http://www.w3.org/2000/svg" style="position:absolute;width:0;height:0;overflow:hidden">
<svg xmlns="http://www.w3.org/2000/svg" class="absolute w-0 h-0 overflow-hidden">
<symbol id="purple-star" viewBox="14 12 72 74">
<defs>
<radialGradient id="starGrad" cx="50%" cy="45%" r="55%">
Expand Down
19 changes: 19 additions & 0 deletions spec/system/footer_help_button_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
require "rails_helper"

# The footer's floating help button is driven by the shared `dropdown`
# controller (no bespoke controller). Clicking it should reveal the help menu
# and clicking again should hide it.
RSpec.describe "Footer help button", type: :system do
it "toggles the help menu open and closed" do
visit faqs_path

expect(page).to have_css("#fab-menu.hidden", visible: :all)

find("#fab-button").click
expect(page).to have_css("#fab-menu:not(.hidden)")
expect(page).to have_link("FAQs")

find("#fab-button").click
expect(page).to have_css("#fab-menu.hidden", visible: :all)
end
end