Remove the footer's inline script and SVG's inline style (CSP)#1986
Closed
maebeale wants to merge 1 commit into
Closed
Remove the footer's inline script and SVG's inline style (CSP)#1986maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
Every page (now including the resource-preview flow this PR reworks) logged two report-only CSP violations from the global layout: the floating help button's inline <script> (script-src) and the SVG sprite's inline style= (default-src). Follow the #1948 precedent — fix the violating markup, keep the strict policy: move the FAB toggle to a Stimulus controller (fab) and the sprite's positioning to utility classes. The remaining console CSP entry is a <style> injected by a JS library (Turbo's progress bar), which would need a CSP nonce to silence. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small markup→Stimulus/utility swap, one new controller, no data changes
What is the goal of this PR and why is this important?
Every page logged two report-only CSP violations from the global layout: the floating help button's inline
<script>(script-src) and the SVG sprite's inlinestyle=(default-src). Removing our own inline script/style keeps the strict CSP enforceable later without'unsafe-inline'.How did you approach the change?
Follow the #1948 precedent — fix the violating markup, keep the strict policy:
fabStimulus controller (fab#toggle, menu/button targets).absolute w-0 h-0 overflow-hidden).Split out of #1976 (resources-clickable) so that PR stays focused on callout resources.
Anything else to add?
The one remaining console CSP entry is a
<style>injected by a JS library (Turbo's progress bar), which would need a CSP nonce to silence — out of scope here.