Fix email edit form to update immediately instead of pending confirmation - #7069
Open
dylangriffinshub wants to merge 2 commits into
Open
Fix email edit form to update immediately instead of pending confirmation#7069dylangriffinshub wants to merge 2 commits into
dylangriffinshub wants to merge 2 commits into
Conversation
…unteers to skip confirmation and improve user experience
dylangriffinshub
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
July 17, 2026 04:41
compwron
previously approved these changes
Jul 21, 2026
Collaborator
|
waiting for CI |
Collaborator
|
Please fix CI and then we can merge :) |
Request specs for casa_admins, volunteers, and supervisors still expected the old unconfirmed_email and confirmation mailer flow. Update them to match the controller behavior already changed in this branch: email updates apply immediately, no confirmation email is sent. Also fix a flash message casing mismatch in the all_casa_admins spec.
Contributor
Author
|
@compwron CI is green now (rspec, lint, brakeman, CodeQL all passing). Ready for another look whenever you have a chance, happy to make any changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6600 — see commit message for details