5563 - Replace helper spec stubs with real tests - #7084
Open
fuentesjr wants to merge 5 commits into
Open
Conversation
fuentesjr
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
July 28, 2026 01:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Part of #5563, intentionally not
Resolves— 16 stub specs remain after this.What changed, and why?
Replaces five
pending "add some tests for X"stubs underspec/helpers/withreal specs (one commit per file), following existing helper-spec style
(
mileage_rates_helper_spec.rb,court_dates_helper_spec.rb):validate_date(parses valid parts,raises
Date::Erroron any blank part) andparse_date(the Railsmultiparameter
(1i)/(2i)/(3i)happy path, the invalid-date path that adds amodel error and leaves the field unset, and the all-blank case that strips the
date-part keys and adds no date)
active_if/active_if_statusselected_organizationreturns theassigned
@casa_org(andnilwhen unassigned)define only constants, so a value assertion is the available real coverage
No production code changed.
How is this tested? (please write rspec and jest tests!) 💖💪
bundle exec rspec spec/helpers/{request_header,template,date,api_base}_helper_spec.rb spec/helpers/all_casa_admins/casa_orgs_helper_spec.rb→ 26 examples, 0 failures
bundle exec standardrbon the five files → no offensespending/skip/xitremains in any of themScreenshots please :)
N/A — test-only change, no UI.
Feelings gif (optional)
N/A