-
-
Notifications
You must be signed in to change notification settings - Fork 232
GHSA/SYNC: 1 new faraday advisory #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasnow
wants to merge
1
commit into
rubysec:master
Choose a base branch
from
jasnow:ghsa-syncbot-2026-05-19-20_33_30
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| --- | ||
| gem: faraday | ||
| cve: 2026-33637 | ||
| ghsa: 5rv5-xj5j-3484 | ||
| url: https://github.com/lostisland/faraday/security/advisories/GHSA-5rv5-xj5j-3484 | ||
| title: Faraday has a possible incomplete fix for GHSA-33mh-2634-fwr2 - | ||
| protocol-relative URI objects still bypass host scoping | ||
| date: 2026-05-18 | ||
| description: | | ||
| ## Summary | ||
|
|
||
| `Faraday::Connection#build_exclusive_url` still allows protocol-relative | ||
| host override when the request target is provided as a `URI` object | ||
| instead of a `String`. This bypasses the February 2026 fix for | ||
| `GHSA-33mh-2634-fwr2` and can redirect a request built from a fixed-base | ||
| `Faraday::Connection` to an attacker-controlled host while preserving | ||
| connection-scoped headers such as `Authorization`. | ||
|
|
||
| ## Supporting Materials | ||
|
|
||
| - Existing advisory for the original string-based issue: GHSA-33mh-2634-fwr2 | ||
| - Existing CVE for the original string-based issue: CVE-2026-25765 | ||
| - Existing regression tests for the string-only fix: | ||
| - spec/faraday/connection_spec.rb:314-345 | ||
| - Existing test proving supported URI request input: | ||
| - spec/faraday/request_spec.rb:26-31 | ||
|
|
||
| ## Impact | ||
|
|
||
| The direct consequence is off-host request forgery from code paths | ||
| that believe they are constrained to a fixed base URL. If the | ||
| connection carries default headers or query parameters, those | ||
| values are forwarded to the attacker-selected host. | ||
| cvss_v3: 0.0 | ||
| unaffected_versions: | ||
| - "< 2.0.0" | ||
| patched_versions: | ||
| - ">= 2.14.2" | ||
| related: | ||
| url: | ||
| - https://nvd.nist.gov/vuln/detail/CVE-2026-33637 | ||
| - https://github.com/lostisland/faraday/releases/tag/v2.14.2 | ||
| - https://github.com/lostisland/faraday/security/advisories/GHSA-5rv5-xj5j-3484 | ||
|
jasnow marked this conversation as resolved.
|
||
| - https://github.com/advisories/GHSA-33mh-2634-fwr2 | ||
| - https://github.com/advisories/GHSA-5rv5-xj5j-3484 | ||
| notes: | | ||
| - ZERO CVSS value in GHSA and NVD | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.