Skip to content

Prefer GitHub Actions.#304

Closed
ioquatix wants to merge 2 commits intomainfrom
prefer-github-actions
Closed

Prefer GitHub Actions.#304
ioquatix wants to merge 2 commits intomainfrom
prefer-github-actions

Conversation

@ioquatix
Copy link
Copy Markdown
Contributor

No description provided.

@trans
Copy link
Copy Markdown
Member

trans commented Mar 26, 2026

Thanks for putting this together — there's a lot of good modernization work here. We're in the process of reviving Facets and agree with most of these changes:

  • Moving to GitHub Actions
  • Removing Ruby 1.8 compat code
  • Removing Enumerable#filter (conflicts with Ruby built-in)
  • Removing taint references
  • URI.escapeCGI.escape
  • Cleaning up require 'facets/enumerator'

However, given Facets' nature as a cherry-pickable library, we need to apply these piecemeal rather than as one large changeset. In particular, the Hash (rekey, deep_rekey, revalue) and OpenStruct deletions need individual evaluation against modern Ruby before removing. There are also a couple of debug lines (pp "LOADING NUDGE", binding.irb) that slipped in.

We'll be incorporating these improvements incrementally. Closing this PR but the work is very much appreciated and will be used.

@trans trans closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants