Skip to content

Comment cleanup#149

Merged
jonathanpallant merged 3 commits into
rust-embedded:mainfrom
thejpster:comment-cleanup
May 1, 2026
Merged

Comment cleanup#149
jonathanpallant merged 3 commits into
rust-embedded:mainfrom
thejpster:comment-cleanup

Conversation

@thejpster
Copy link
Copy Markdown
Contributor

@thejpster thejpster commented Mar 28, 2026 •
edited by jonathanpallant
Loading

Comment updates.

  • Turned on deny(missing_docs), and added missing docs
  • Turned on deny(clippy::missing_safety_doc) and added missing safety docs
  • Turned on some more useful lints
  • Clippy fixes
  • Rationalised/renamed the various CachePolicy types

@wt
Copy link
Copy Markdown

wt commented Apr 1, 2026

I'm curious. Did you write all of these or is this generated from some other source?

@thejpster
Copy link
Copy Markdown
Contributor Author

thejpster commented Apr 1, 2026

Mostly copy-pasted from the arm Arm ARM.

@thejpster thejpster changed the title Comment cleanup Comment cleanup (includes #131) Apr 3, 2026
@robamu
Copy link
Copy Markdown
Contributor

robamu commented Apr 16, 2026 •
edited
Loading

I am a bit confused. This was rebased, but I thought this only includes docs updates, but I still see various new test cases etc. in the changes?

@robamu
Copy link
Copy Markdown
Contributor

robamu commented Apr 16, 2026

Ah, I get it. #131 was not merged yet :)

@jonathanpallant
Copy link
Copy Markdown
Contributor

jonathanpallant commented Apr 18, 2026

#131 is in so I'll rebase this

@thejpster thejpster force-pushed the comment-cleanup branch 3 times, most recently from d351452 to bf3f8f3 Compare April 18, 2026 17:10
@jonathanpallant jonathanpallant mentioned this pull request Apr 21, 2026
Merged
@jonathanpallant
Copy link
Copy Markdown
Contributor

jonathanpallant commented Apr 21, 2026

#158 updates the tests to use the non-deprecated function, so this PR now needs re-working to not un-deprecate the function.

@jonathanpallant
Copy link
Copy Markdown
Contributor

jonathanpallant commented Apr 21, 2026

Re-worked to leave the process function deprecated.

@jonathanpallant jonathanpallant changed the title Comment cleanup (includes #131) Comment cleanup Apr 22, 2026
@jonathanpallant
Copy link
Copy Markdown
Contributor

jonathanpallant commented Apr 22, 2026

I'm moving the arm-targets stuff to another PR because it's orthogonal

@jonathanpallant jonathanpallant mentioned this pull request Apr 22, 2026
Closed
@jonathanpallant jonathanpallant added this pull request to the merge queue Apr 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 28, 2026
@jonathanpallant
Copy link
Copy Markdown
Contributor

jonathanpallant commented Apr 28, 2026 •
edited
Loading

this needs a patch.crates-io entry so we don't have two aarch32-cpu crates in the tree (also aarch32-cpu 0.2 has issues it seems).

Maybe I'll take out the aarch32-cpu dependency from pl190-vic and use inline assembly instead.

@thejpster
Copy link
Copy Markdown
Contributor Author

thejpster commented Apr 29, 2026

I think it's important people can use multiple copies of the aarch32-cpu crate, so I moved the __sync_synchronize function into aarch32-rt (which is full of unmangled symbols already). The versatileab carries a patch to modify pl190-vic to use the latest aarch32-cpu crate to work-around the issue. The patch can be dropped once pl190-vic uses an aarch32-cpu crate without the unmangled symbol in it.

@thejpster thejpster mentioned this pull request Apr 29, 2026
Merged
@thejpster thejpster requested a review from robamu April 29, 2026 11:11
robamu
robamu reviewed Apr 30, 2026
View reviewed changes
Comment thread aarch32-cpu/src/register/armv8r/hmpuir.rs Outdated
thejpster added 3 commits May 1, 2026 14:47
@thejpster @jonathanpallant
Comment updates.
b6f5382 
* Turned on deny(missing_docs), and added missing docs
* Turned on deny(clippy::missing_safety_doc) and added missing safety docs
* Turned on some more useful lints
* Clippy fixes
* Rationalised/renamed the various CachePolicy types
* Make SysReg and SysReg64 have safe read methods
@thejpster @jonathanpallant
Move __sync_synchronize into aarch32-rt.
caab1fe 
You only have one rt crate per build, but may have multiple copies of
aarch32-cpu, and an unmangled symbol breaks that.
@thejpster @jonathanpallant
Use unsafe(no_mangle) instead of no_mangle.
cda9a30
@jonathanpallant jonathanpallant added this pull request to the merge queue May 1, 2026
Merged via the queue into rust-embedded:main with commit 93282b9 May 1, 2026
52 checks passed
@thejpster thejpster deleted the comment-cleanup branch May 1, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanpallant jonathanpallant jonathanpallant left review comments

@robamu robamu robamu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thejpster @wt @robamu @jonathanpallant