Skip to content

use cortex-m-types crate for the InterruptNumber trait#959

Merged
burrbull merged 3 commits into
rust-embedded:masterfrom
robamu:use-cortex-m-types
Apr 25, 2026
Merged

use cortex-m-types crate for the InterruptNumber trait#959
burrbull merged 3 commits into
rust-embedded:masterfrom
robamu:use-cortex-m-types

Conversation

@robamu
Copy link
Copy Markdown
Contributor

@robamu robamu commented Apr 25, 2026

this is a part of the effort to make updating cortex-m easier. PACs can now depend on cortex-m-types instead of cortex-m

@robamu robamu requested a review from a team as a code owner April 25, 2026 09:36
@burrbull
Copy link
Copy Markdown
Member

Makes sense. Could you add discussion link in first message, please?

@robamu
Copy link
Copy Markdown
Contributor Author

robamu commented Apr 25, 2026

which discussion link? this PR?

@robamu
Copy link
Copy Markdown
Contributor Author

robamu commented Apr 25, 2026

Also had to bump the MSRV.

@burrbull
Copy link
Copy Markdown
Member

which discussion link?

Where cortex-m-types was introduced.

@robamu
Copy link
Copy Markdown
Contributor Author

robamu commented Apr 25, 2026

I can not find it. maybe because cortex-m was not always a mono-repo?

@burrbull
Copy link
Copy Markdown
Member

/ci diff

@burrbull burrbull added this pull request to the merge queue Apr 25, 2026
Merged via the queue into rust-embedded:master with commit 540d31e Apr 25, 2026
59 checks passed
@adamgreig
Copy link
Copy Markdown
Member

Might be worth a note that PACs generated using cortex-m-types won't export an InterruptNumber that works with current cortex-m's NVIC (https://docs.rs/cortex-m/latest/cortex_m/peripheral/struct.NVIC.html). I think we can publish a new cortex-m 0.7.x that has a blanket impl of its InterruptNumber trait for the one from cortex-m-types that would maintain compatibility, but need to check that actually works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants