josh-proxy shutdown: try longer and reduce slack#49
Merged
Conversation
RalfJung
force-pushed
the
josh-proxy-shutdown
branch
from
65f8e12 to
83ca1b3
Compare
Member
Author
|
I also added a SIGTERM to the shutdown loop which seems to be needed for newer josh versions. |
RalfJung
force-pushed
the
josh-proxy-shutdown
branch
from
83ca1b3 to
65f8e12
Compare
Member
Author
I have un-done this again since josh upstream is being fixed (josh-project/josh#2012). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a single 100ms wait, let's do 10ms waits and give it a total of a second. This is more robust against slow shutdowns, while also being quicker if shutdown happens to be fast.
This matches what we do on startup when we wait for the port to become available.