Clarify UTF-16 decoding errors#149696
Conversation
This comment has been minimized.
This comment has been minimized.
0517c75 to
ccbfc0b
Compare
This comment has been minimized.
This comment has been minimized.
ccbfc0b to
1cc01e7
Compare
This comment has been minimized.
This comment has been minimized.
2279962 to
78830b4
Compare
This comment has been minimized.
This comment has been minimized.
78830b4 to
693dc90
Compare
|
☔ The latest upstream changes (presumably #149836) made this pull request unmergeable. Please resolve the merge conflicts. |
693dc90 to
8fedc80
Compare
This comment has been minimized.
This comment has been minimized.
8fedc80 to
5ff0ec6
Compare
|
Implementation-wise this looks fine (modulo the nit). I'll reassign this to libs-api though, in case they have comments... r? libs-api |
Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>
b07bde2 to
f7444d4
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r+ I’m not part of libs-api but they’ve had ample opportunity to comment. I’ll take it on myself to evaluate that this PR correctly addresses the one blocking FCP concern from #116258 (comment) |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing a31c27a (parent) -> 5ea817c (this PR) Test differencesShow 307 test diffs307 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 5ea817c65e4896167300b7d2550781b98da9901a --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (5ea817c): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 510.693s -> 511.688s (0.19%) |
Fix UTF-16 error messages as suggested in #116258.