Skip to content

Clarify UTF-16 decoding errors#149696

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
jnodorp:clarify-utf16-errors
May 18, 2026
Merged

Clarify UTF-16 decoding errors#149696
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
jnodorp:clarify-utf16-errors

Conversation

@jnodorp
Copy link
Copy Markdown
Contributor

@jnodorp jnodorp commented Dec 5, 2025

Fix UTF-16 error messages as suggested in #116258.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 5, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Dec 5, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@jnodorp jnodorp force-pushed the clarify-utf16-errors branch from 0517c75 to ccbfc0b Compare December 5, 2025 22:37
@rust-log-analyzer

This comment has been minimized.

@jnodorp jnodorp force-pushed the clarify-utf16-errors branch from ccbfc0b to 1cc01e7 Compare December 5, 2025 23:30
@rust-log-analyzer

This comment has been minimized.

@jnodorp jnodorp force-pushed the clarify-utf16-errors branch 2 times, most recently from 2279962 to 78830b4 Compare December 7, 2025 22:02
@rustbot

This comment has been minimized.

Comment thread library/alloc/src/string.rs Outdated
@jnodorp jnodorp force-pushed the clarify-utf16-errors branch from 78830b4 to 693dc90 Compare December 8, 2025 09:55
@bors
Copy link
Copy Markdown
Collaborator

bors commented Dec 10, 2025

☔ The latest upstream changes (presumably #149836) made this pull request unmergeable. Please resolve the merge conflicts.

@jnodorp jnodorp force-pushed the clarify-utf16-errors branch from 693dc90 to 8fedc80 Compare December 11, 2025 08:51
@rustbot

This comment has been minimized.

@jnodorp jnodorp force-pushed the clarify-utf16-errors branch from 8fedc80 to 5ff0ec6 Compare December 11, 2025 08:52
Comment thread library/alloc/src/string.rs Outdated
@joboet
Copy link
Copy Markdown
Member

joboet commented Dec 16, 2025

Implementation-wise this looks fine (modulo the nit). I'll reassign this to libs-api though, in case they have comments...

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 16, 2025
@rustbot rustbot assigned the8472 and unassigned joboet Dec 16, 2025
jnodorp and others added 2 commits February 26, 2026 08:57
Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>
@jnodorp jnodorp force-pushed the clarify-utf16-errors branch from b07bde2 to f7444d4 Compare February 26, 2026 07:57
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 26, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@SimonSapin
Copy link
Copy Markdown
Contributor

@bors r+

I’m not part of libs-api but they’ve had ample opportunity to comment. I’ll take it on myself to evaluate that this PR correctly addresses the one blocking FCP concern from #116258 (comment)

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 18, 2026

📌 Commit f7444d4 has been approved by SimonSapin

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 18, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 18, 2026

☀️ Test successful - CI
Approved by: SimonSapin
Duration: 3h 22m 54s
Pushing 5ea817c to main...

@rust-bors rust-bors Bot merged commit 5ea817c into rust-lang:main May 18, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a31c27a (parent) -> 5ea817c (this PR)

Test differences

Show 307 test diffs

307 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5ea817c65e4896167300b7d2550781b98da9901a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. i686-msvc-2: 1h 41m -> 2h 17m (+35.2%)
  2. aarch64-apple: 2h 38m -> 3h 15m (+23.3%)
  3. dist-arm-linux-gnueabi: 1h 12m -> 1h 28m (+22.9%)
  4. pr-check-1: 33m 45s -> 26m 54s (-20.3%)
  5. optional-x86_64-gnu-parallel-frontend: 2h 48m -> 2h 21m (-16.3%)
  6. i686-gnu-1: 2h 26m -> 2h 4m (-15.5%)
  7. i686-gnu-2: 1h 46m -> 1h 30m (-15.3%)
  8. x86_64-rust-for-linux: 55m 47s -> 47m 24s (-15.0%)
  9. aarch64-msvc-2: 2h -> 1h 43m (-14.4%)
  10. x86_64-gnu-llvm-21-1: 57m 33s -> 49m 25s (-14.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@jnodorp jnodorp deleted the clarify-utf16-errors branch May 18, 2026 08:47
@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (5ea817c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.3% [-5.7%, -0.9%] 2
All ❌✅ (primary) - - 0

Cycles

Results (primary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-2.6%, 2.0%] 2

Binary size

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) - - 0

Bootstrap: 510.693s -> 511.688s (0.19%)
Artifact size: 400.56 MiB -> 400.54 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants