test(chore): audit `//@ run-pass` in ui tests by Embers-of-the-Fire · Pull Request #154254 · rust-lang/rust

Embers-of-the-Fire · 2026-03-23T11:14:47Z

Part of work for #154158.

rustbot · 2026-03-23T16:23:38Z

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 14 candidates

JonathanBrouwer · 2026-03-23T18:54:36Z

@rustbot reroll
I'm very busy in my personal life this week and probably the next one as well so will leave review duty for a bit (just changed my triagebot config)

TaKO8Ki · 2026-03-24T09:22:54Z

Thank you. Could you let me know when you're ready with @rustbot review and rebase all commits into a single commit at the end? @Embers-of-the-Fire

@rustbot author

rustbot · 2026-03-24T09:23:00Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Embers-of-the-Fire · 2026-05-09T12:30:25Z

@rustbot review

TaKO8Ki · 2026-05-11T07:59:32Z

@Embers-of-the-Fire Could you fix CI failures?

Embers-of-the-Fire · 2026-05-12T07:01:16Z

@TaKO8Ki Most of the errors (at least those I could observe) originate from linter warnings, and I'm not sure if you want me to fix them by 1) switching back to build-pass or run-pass or 2) modify the stderr file?

TaKO8Ki · 2026-05-12T08:42:24Z

@Embers-of-the-Fire These look like stale stderr expectations after the mode change. The actual output is empty, I guess. You can keep check-pass and remove/bless the stale .stderr files with --bless as an example.

rustbot · 2026-05-14T14:20:38Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Assisted-by: OpenAI:gpt-5.5 Co-authored-by: Ayuse <ayodeleoluwasina@gmail.com> Signed-off-by: Embers-of-the-Fire <stellarishs@163.com>

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 23, 2026

Embers-of-the-Fire changed the title ~~text(chore): audit //@ run-pass in ui tests~~ test(chore): audit //@ run-pass in ui tests Mar 23, 2026

Embers-of-the-Fire marked this pull request as ready for review March 23, 2026 16:23

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2026

rustbot assigned JonathanBrouwer Mar 23, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 23, 2026

rustbot assigned TaKO8Ki and unassigned JonathanBrouwer Mar 23, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2026