Skip to content

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets#156284

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
petrochenkov:kvak2
May 12, 2026
Merged

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets#156284
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
petrochenkov:kvak2

Conversation

@petrochenkov
Copy link
Copy Markdown
Contributor

@petrochenkov petrochenkov commented May 7, 2026

Fixes #156264.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 7, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 7, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@petrochenkov petrochenkov mentioned this pull request May 7, 2026
Closed
@petrochenkov
Copy link
Copy Markdown
Contributor Author

petrochenkov commented May 7, 2026

The proper fix requires landing #149195 first, and may potentially cause some performance issues.

@meditationmind meditationmind mentioned this pull request May 10, 2026
Merged
@petrochenkov
Copy link
Copy Markdown
Contributor Author

petrochenkov commented May 12, 2026

r? @mu001999

@rustbot rustbot assigned mu001999 and unassigned JohnTitor May 12, 2026
@mu001999

This comment was marked as outdated.

Sign in to view
1 similar comment
@mu001999
Copy link
Copy Markdown
Member

mu001999 commented May 12, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 12, 2026

📌 Commit 235fa6b has been approved by mu001999

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 12, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156506 - JonathanBrouwer:rollup-sOIgP3l, r=JonathanBro…
561d401 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156428 (Move `std::io::Cursor` to `core::io`)
 - #156431 (Move `std::io::util` to `core::io`)
 - #156145 (Move tests cast)
 - #156284 (resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets)
 - #156502 (Give an example of a Ctor in the doc-comments)
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156506 - JonathanBrouwer:rollup-sOIgP3l, r=JonathanBro…
8b03437 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156428 (Move `std::io::Cursor` to `core::io`)
 - #156431 (Move `std::io::util` to `core::io`)
 - #156145 (Move tests cast)
 - #156284 (resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets)
 - #156502 (Give an example of a Ctor in the doc-comments)
@rust-bors rust-bors Bot merged commit 63322d0 into rust-lang:main May 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 12, 2026
rust-timer added a commit that referenced this pull request May 12, 2026
@rust-timer
Unrolled build for #156284
27617b5 
Rollup merge of #156284 - petrochenkov:kvak2, r=mu001999

resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets

Fixes #156264.
@Mark-Simulacrum
Copy link
Copy Markdown
Member

Mark-Simulacrum commented May 17, 2026

@rust-timer build 27617b5

cc #156506 (comment)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented May 17, 2026

Finished benchmarking commit (27617b5): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.9% [-1.0%, -0.8%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Binary size

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 510.527s -> 508.407s (-0.42%)
Artifact size: 400.06 MiB -> 400.06 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mu001999 mu001999

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

E0365 newly triggers on pub(crate) reexports (cannot be re-exported outside)

6 participants

@petrochenkov @rustbot @mu001999 @Mark-Simulacrum @rust-timer @JohnTitor