compiletest: Enforce that directives are consistently used with or without a colon#156450
Merged
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
jieyouxu
approved these changes
May 14, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
May 14, 2026
Rollup merge of #156450 - Zalathar:colon-or-not, r=jieyouxu compiletest: Enforce that directives are consistently used with or without a colon With the notable exception of `//@ pp-exact`, all directives expect to either always be used *with* a colon, or always be used *without* a colon. For example: - `//@ uses-colon: value` - `//@ no-colon` or `//@ no-colon (remark)` Currently we just silently discard directives that use the wrong syntax, which is not great. This PR therefore makes `parse_name_directive` and `parse_name_value_directive` panic if the wrong syntax is encountered. The parser for `pp-exact` has been adjusted to check for the colon before deciding which parse method to call. r? jieyouxu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the notable exception of
//@ pp-exact, all directives expect to either always be used with a colon, or always be used without a colon. For example://@ uses-colon: value//@ no-colonor//@ no-colon (remark)Currently we just silently discard directives that use the wrong syntax, which is not great.
This PR therefore makes
parse_name_directiveandparse_name_value_directivepanic if the wrong syntax is encountered.The parser for
pp-exacthas been adjusted to check for the colon before deciding which parse method to call.r? jieyouxu