Enable -Znext-solver on nightly by default

[Kivooeo]

View all comments

Implementation of rust-lang/compiler-team#1014 cc rust-lang/blog.rust-lang.org#1896 #160895

This enables -Znext-solver=globally by default in nightly, but keeps -Znext-solver=coherence for tests

[lcnr]

@bors r+ rollup=never

[rust-bors]

📌 Commit 1311d86 has been approved by lcnr

It is now in the queue for this repository.

[rust-bors]

💔 Test for 13afda5 failed: CI. Failed job:

• auto - x86_64-gnu-stable (web logs, enhanced plaintext logs)

[Kobzol]

@bors try @rust-timer queue

[Kobzol]

Heh, I noticed the failing test while reading the code and was thinking "huh, how does this work?". And now I see it doesn't 😆 It either has to be skipped on nightly, or perhaps I'd just replace it with a check that compares the parsed value to the Default impl of the next solver config.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 97e0817 (97e0817e27d8579734e091d063da910298d6891d)
Base parent: 0cfa1c4 (0cfa1c40c6a6165adbcdb2bc5f973a9d7389186e)

[lcnr]

not part of this PR, but we allow coherence: bool = true even without derive(Default) that's surprising to me 🤔

View changes since the review

[lcnr]

enabling the tracked check if the next-solver is enabled in 72c9724

I guess let's wait for perf before reapproving :>

[rust-timer]

Finished benchmarking commit (97e0817): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.1%, 1.6%]	119
Regressions ❌ (secondary)	0.5%	[0.0%, 1.7%]	151
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-8.1%, -0.3%]	27
All ❌✅ (primary)	0.6%	[0.1%, 1.6%]	119

Max RSS (memory usage)

Results (primary 1.3%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.9%, 3.1%]	8
Regressions ❌ (secondary)	2.0%	[0.8%, 3.2%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-3.1%, -0.6%]	13
All ❌✅ (primary)	1.3%	[0.9%, 3.1%]	8

Cycles

Results (primary 2.5%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	6.9%	[5.0%, 8.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-4.1%, -2.3%]	7
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Binary size

Results (primary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	3

Bootstrap: 456.922s -> 480.397s (5.14%)
Artifact size: 398.89 MiB -> 400.06 MiB (0.29%)

[jdonszelmann]

@bors r=lcnr,jdonszelmann,kobzol

[rust-bors]

📌 Commit 72c9724 has been approved by lcnr,jdonszelmann,kobzol

It is now in the queue for this repository.