Checked/wrapping/unbounded funnel shifts - #161119
Open
pthariensflame wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
tgross35
added
the
S-waiting-on-ACP
Member
|
ACP at rust-lang/libs-team#855 |
This was referenced Aug 15, 2026
tgross35
reviewed
Aug 20, 2026
| /// This function will return `None` if `n` is greater than or equal to the number of | ||
| /// bits in `self`, i.e. when [`funnel_shl`](Self::funnel_shl) would panic. | ||
| #[rustc_const_unstable(feature = "wrapping_funnel_shifts", issue = "none")] | ||
| #[unstable(feature = "wrapping_funnel_shifts", issue = "none")] |
Member
There was a problem hiding this comment.
Please create a new tracking issue. I think it's fine to do even before the ACP is accepted
Contributor
Author
There was a problem hiding this comment.
We will update this PR when we are next back at our computer on Monday for other reasons anyway (adding strict versions, adding tests), so we will make a tracking issue and list it then too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the wrapping funnel shifts requested at rust-lang/libs-team#642 (comment) and also some additional forms of funnel shift proposed at rust-lang/libs-team#855; this might interact with #161015, which is attempting to stabilize the original funnel shift methods.
The work in this PR was done entirely by some people inside a human brain, without the use of any LLMs…or much use of an IDE since ours kept crashing during this process and we had to resort to a plain text editor. 😅