[crater] Also enforce dyn compatibility in (unchecked) type aliases - #161358
Draft
fmease wants to merge 1 commit into
Draft
[crater] Also enforce dyn compatibility in (unchecked) type aliases#161358fmease wants to merge 1 commit into
fmease wants to merge 1 commit into
Conversation
fmease
added
needs-fcp
rustbot
added
S-waiting-on-author
fmease
removed
the
S-waiting-on-author
Member
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 19, 2026
…try> [crater] Also enforce dyn compatiblity in (unchecked) type aliases
fmease
changed the title
fmease
commented
Aug 19, 2026
Member
Author
There was a problem hiding this comment.
This test didn't make much sense to me: "[…] are rejected at the definition site of an eager type alias.": Well yeah, but it had to reference the type alias somewhere (here: in the body of main) for that to happen, so it isn't testing what it says. After all, unchecked type aliases aren't retained in the middle::ty IR, they're eagerly expanded to their RHS, so this behavior has nothing to do with type aliases.
Because of that, I've removed it.
Contributor
Member
Author
|
@craterbot check |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
enf-dyn-compat-in-unck-ty-aliases
branch
3 times, most recently
from
August 19, 2026 16:30
32330c2 to
a16442e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #t-types/nominated > #157710: Prohibit conflicting bounds in `dyn`, even with di… @ 💬.
(No LLM was used in the creation of this PR)