Rollup of 16 pull requests by JonathanBrouwer · Pull Request #161399 · rust-lang/rust

JonathanBrouwer · 2026-08-20T14:01:19Z

Successful merges:

std: implement sleep_until for Fuchsia #152617 (std: implement sleep_until for Fuchsia)
diagnostics: fix let x: vec![] suggestion pointing into stdlib #158934 (diagnostics: fix let x: vec![] suggestion pointing into stdlib)
bootstrap: Move all non-module items out of the crate root #161277 (bootstrap: Move all non-module items out of the crate root)
std: don't panic on long-elapsed deadlines for sleep_until #161295 (std: don't panic on long-elapsed deadlines for sleep_until)
Double-word align _Unwind_Exception #161368 (Double-word align _Unwind_Exception)
Uplift rustfmt macro formatting fix #161370 (Uplift rustfmt macro formatting fix)
FlowSensitiveAnalysis cleanups #161378 (FlowSensitiveAnalysis cleanups)
Offload expose device selection #158032 (Offload expose device selection)
Add desktop method to CommandExt #158855 (Add desktop method to CommandExt)
core: Make funnel shifts panic only if overflow checks are enabled #161204 (core: Make funnel shifts panic only if overflow checks are enabled)
Add regression tests for a few fixed issues with E-needs-test #161329 (Add regression tests for a few fixed issues with E-needs-test)
Add regression test for nested RPIT not an iterator ICE #161330 (Add regression test for nested RPIT not an iterator ICE)
Cleanup: Move impl of #[rustc_dump_object_lifetime_defaults] #161351 (Cleanup: Move impl of #[rustc_dump_object_lifetime_defaults])
Add file path to some archive build errors #161355 (Add file path to some archive build errors)
Allow running EC2 jobs locally #161373 (Allow running EC2 jobs locally)
Configure LLM policy URL for triagebot #161393 (Configure LLM policy URL for triagebot)

Adds the `desktop` method to the Windows `CommandExt` trait to enable setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call.

…ribute

…'s `macro_rules!`

…d tabs

I wasn't able to find a test that verifies different behavior based on whether or not overflow checks are available, so add one here.

This would have been useful to have while debugging a problem in cg_clif.

When a macro call like `vec![]` appears in type position, the compiler's "use `=` if you meant to assign" suggestion was pointing into the macro definition in stdlib instead of the user's own code. The suggestion span was computed as `stmt.pat.span.between(hir_ty.span)`. After expansion `hir_ty.span` lies inside the macro body, so that span crossed syntax contexts and the renderer displayed the stdlib location. Compute the span via `find_ancestor_in_same_ctxt` instead, so the pattern and the type are compared in a common syntax context. When no common context exists -- e.g. the `let` comes from a macro body while the pattern is a call-site metavariable -- no suggestion is emitted at all.

There are only three impls of `Qualif`, and the extra explicitness is clearer.

Items with implicit `pub(self)` visibility in the crate root are effectively `pub(crate)`, which causes friction when trying to move them elsewhere.

This intermediate commit helps to preserve line history.

Change from the existing behavior of panicking unconditionally to panicking only if debug assertions are enabled, wrapping otherwise. This is more consistent with other operations, and gives slightly better codegen [1]. Suggested in the stabilization PR, RUST-161015. [1]: https://rust.godbolt.org/z/Yz81zhbno

@jyn514

Configure LLM policy URL for triagebot Implemented in rust-lang/triagebot#2486, documented in rust-lang/rust-forge#1099. CC @jyn514 r? Urgau

JonathanBrouwer · 2026-08-20T14:01:33Z

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-1,aarch64-apple-2,x86_64-mingw-1,i686-msvc-1,i686-msvc-2

rust-bors · 2026-08-20T14:01:36Z

📌 Commit 9f8402b has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: Main branch is broken

rust-bors · 2026-08-20T14:01:43Z

⌛ Trying commit 9f8402b with merge 7fa0181…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/32377677788

Rollup of 16 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2

rust-log-analyzer · 2026-08-20T14:59:56Z

The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] core test:false 17.842
error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:235:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 235 | |             let _ = <$T>::funnel_shl(A, B, A);
     | |                     ----------------       ^ expected `u32`, found `u128`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u128.rs:1:1
     |
   1 |   uint_module!(u128);
     |   ------------------ in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:567:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 567 | |         pub const fn funnel_shl(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
1380 | |     }
     | |_____- in this macro invocation
help: you can convert a `u128` to a `u32` and panic if the converted value doesn't fit
     |
 235 |             let _ = <$T>::funnel_shl(A, B, A.try_into().unwrap());
     |                                             ++++++++++++++++++++

error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:241:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 241 | |             let _ = <$T>::funnel_shr(A, B, B);
     | |                     ----------------       ^ expected `u32`, found `u128`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u128.rs:1:1
     |
   1 |   uint_module!(u128);
     |   ------------------ in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:638:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 638 | |         pub const fn funnel_shr(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
1380 | |     }
     | |_____- in this macro invocation
help: you can convert a `u128` to a `u32` and panic if the converted value doesn't fit
     |
 241 |             let _ = <$T>::funnel_shr(A, B, B.try_into().unwrap());
     |                                             ++++++++++++++++++++

error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:235:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 235 | |             let _ = <$T>::funnel_shl(A, B, A);
     | |                     ----------------       ^ expected `u32`, found `u16`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u16.rs:1:1
     |
   1 |   uint_module!(u16);
     |   ----------------- in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:567:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 567 | |         pub const fn funnel_shl(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
1258 | |     }
     | |_____- in this macro invocation
help: you can convert a `u16` to a `u32`
     |
 235 |             let _ = <$T>::funnel_shl(A, B, A.into());
     |                                             +++++++

error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:241:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 241 | |             let _ = <$T>::funnel_shr(A, B, B);
     | |                     ----------------       ^ expected `u32`, found `u16`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u16.rs:1:1
     |
   1 |   uint_module!(u16);
     |   ----------------- in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:638:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 638 | |         pub const fn funnel_shr(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
1258 | |     }
     | |_____- in this macro invocation
help: you can convert a `u16` to a `u32`
     |
 241 |             let _ = <$T>::funnel_shr(A, B, B.into());
     |                                             +++++++

error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:235:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 235 | |             let _ = <$T>::funnel_shl(A, B, A);
     | |                     ----------------       ^ expected `u32`, found `u64`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u64.rs:1:1
     |
   1 |   uint_module!(u64);
     |   ----------------- in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:567:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 567 | |         pub const fn funnel_shl(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
1346 | |     }
     | |_____- in this macro invocation
help: you can convert a `u64` to a `u32` and panic if the converted value doesn't fit
     |
 235 |             let _ = <$T>::funnel_shl(A, B, A.try_into().unwrap());
     |                                             ++++++++++++++++++++

error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:241:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 241 | |             let _ = <$T>::funnel_shr(A, B, B);
     | |                     ----------------       ^ expected `u32`, found `u64`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u64.rs:1:1
     |
   1 |   uint_module!(u64);
     |   ----------------- in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:638:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 638 | |         pub const fn funnel_shr(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
1346 | |     }
     | |_____- in this macro invocation
help: you can convert a `u64` to a `u32` and panic if the converted value doesn't fit
     |
 241 |             let _ = <$T>::funnel_shr(A, B, B.try_into().unwrap());
     |                                             ++++++++++++++++++++

error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:235:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 235 | |             let _ = <$T>::funnel_shl(A, B, A);
     | |                     ----------------       ^ expected `u32`, found `u8`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u8.rs:1:1
     |
   1 |   uint_module!(u8);
     |   ---------------- in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:567:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 567 | |         pub const fn funnel_shl(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
 610 | |     }
     | |_____- in this macro invocation
help: you can convert a `u8` to a `u32`
     |
 235 |             let _ = <$T>::funnel_shl(A, B, A.into());
     |                                             +++++++

error[E0308]: mismatched types
    --> library/coretests/tests/num/uint_macros.rs:241:44
     |
   1 | / macro_rules! uint_module {
   2 | |     ($T:ident) => {
   3 | |         use core::num::ParseIntError;
   4 | |         use core::ops::{BitAnd, BitOr, BitXor, Not, Shl, Shr};
...    |
 241 | |             let _ = <$T>::funnel_shr(A, B, B);
     | |                     ----------------       ^ expected `u32`, found `u8`
     | |                     |
     | |                     arguments to this function are incorrect
...    |
 840 | |     };
 841 | | }
     | |_- in this expansion of `uint_module!`
     |
    ::: library/coretests/tests/num/u8.rs:1:1
     |
   1 |   uint_module!(u8);
     |   ---------------- in this macro invocation
     |
note: method defined here
    --> library/core/src/num/uint_macros.rs:638:22
     |
   1 | / macro_rules! uint_impl {
   2 | |     (
   3 | |         Self = $SelfT:ty,
   4 | |         ActualT = $ActualT:ident,
...    |
 638 | |         pub const fn funnel_shr(self, right: Self, n: u32) -> Self {
     | |                      ^^^^^^^^^^
...    |
4410 | | }
     | |_- in this expansion of `uint_impl!`
     |
---
 610 | |     }
     | |_____- in this macro invocation
help: you can convert a `u8` to a `u32`
     |
 241 |             let _ = <$T>::funnel_shr(A, B, B.into());
     |                                             +++++++

For more information about this error, try `rustc --explain E0308`.
[RUSTC-TIMING] coretests test:true 41.157
error: could not compile `coretests` (test "coretests") due to 8 previous errors

rust-bors · 2026-08-20T15:13:11Z

PR #161204, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

Axel Rousselot and others added 30 commits July 6, 2026 18:21

Add desktop method to CommandExt

d33b74b

Adds the `desktop` method to the Windows `CommandExt` trait to enable setting the `lpDesktop` field of the STARTUPINFO passed to the Windows `CreateProcess` API call.

get number of devices intrinisc

c266bb2

Add device arg to offload intrinisc

efbb356

Add a regression test for a panicking proc macro used as an inner att…

ed486fb

…ribute

Add a regression test for a macro_rules! generated by another crate…

652eb84

…'s `macro_rules!`

Add a regression test for full LTO against rustc_private

d9d3a21

Add a regression test for eliding the middle of a span containing har…

f18340b

…d tabs

std: Add a test for operations that depend on overflow checks

c83b0a4

I wasn't able to find a test that verifies different behavior based on whether or not overflow checks are available, so add one here.

std: don't panic on long-elapsed deadlines for sleep_until

dd69e6b

Add a regression test for wrapping arithmetic under MIR optimisations

d448db8

Add regression test for nested RPIT not-an-iterator ICE

ceeaac0

Cleanup: Move impl of #[rustc_dump_object_lifetime_defaults]

8ac67c5

Add file path to some archive build errors

eae69d8

This would have been useful to have while debugging a problem in cg_clif.

Uplift rustfmt macro formatting fix

d827d44

Update with macro and some tweaks

3777642

Allow running EC2 jobs locally

f11d76f

Fix obvious copy/paste bug in State::fmt_diff_with

6c99f69

Remove unnecessary arg from FlowSensitiveAnalysis::new

dffe277

Factor out duplicated code in Qualifs

c7ead52

Remove defaults for Qualif assoc consts

6229d6d

There are only three impls of `Qualif`, and the extra explicitness is clearer.

Pre-adjust visibility of pub items in lib.rs

bb9cd32

Pre-adjust visibility of default-visibility items in lib.rs

651d501

Items with implicit `pub(self)` visibility in the crate root are effectively `pub(crate)`, which causes friction when trying to move them elsewhere.

Pre-adjust imports from the crate root

72e9e0e

Temporarily rename lib.rs to session.rs

f068a50

This intermediate commit helps to preserve line history.

Move all non-module items out of the crate root

91374a5

Configure LLM policy URL for triagebot

0ff906a

Double-word align _Unwind_Exception

ac623ff

std: update definitions on Fuchsia

ed151ed

Rollup merge of rust-lang#161393 - Kobzol:llm-policy-url, r=Urgau

9f8402b

Configure LLM policy URL for triagebot Implemented in rust-lang/triagebot#2486, documented in rust-lang/rust-forge#1099. CC @jyn514 r? Urgau

rust-bors Bot added the rollup A PR which is a rollup label Aug 20, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026

JonathanBrouwer mentioned this pull request Aug 20, 2026

core: Make funnel shifts panic only if overflow checks are enabled #161204

Open

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 20, 2026

JonathanBrouwer closed this Aug 20, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 20, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 16 pull requests - #161399

Rollup of 16 pull requests#161399
JonathanBrouwer wants to merge 49 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-pgMyu6e

JonathanBrouwer commented Aug 20, 2026

Uh oh!

JonathanBrouwer commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026 •

edited

Loading

Uh oh!

rust-log-analyzer commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Aug 20, 2026

Uh oh!

JonathanBrouwer commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

rust-bors Bot commented Aug 20, 2026 •

edited

Loading