feat: add unwrap_or_raise_itself() if a value of Err is a BaseException#199
Open
Colk-tech wants to merge 6 commits intorustedpy:mainfrom
Open
feat: add unwrap_or_raise_itself() if a value of Err is a BaseException#199Colk-tech wants to merge 6 commits intorustedpy:mainfrom
unwrap_or_raise_itself() if a value of Err is a BaseException#199Colk-tech wants to merge 6 commits intorustedpy:mainfrom
Conversation
Colk-tech
commented
Oct 28, 2024
Comment on lines
+376
to
+379
| raise UnwrapError( | ||
| self, | ||
| f"Called `Result.unwrap_or_raise_itself()` on non-exception value: {self._value}", | ||
| ) |
Author
There was a problem hiding this comment.
Which is preferred to raise, UnwrapError, TypeError or ValueError?
unwrap_or_raise_itself() if the value of Err is a BaseExceptionunwrap_or_raise_itself() if a value of Err is a BaseException
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances #192. If this is merged, Close: #192.
Rather than overriding the existing behavior of
unwrap_or_raise(), I added a new method:unwrap_or_raise_itself().With this addition, users can better determine if an Err value is a BaseException. This option may be helpful in such cases.
The unwrap_or_raise_itself() method is now available in both Ok and Err classes.
Example:
By the way, this is my first time creating a PR for an OSS project, so I’d be grateful for any advice you might have :)