Merged
Conversation
Blindly convert local to const keywords Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to use Luau’s const declarations in places where bindings are not intended to be reassigned, aligning implementation files and docs examples with that immutability intent.
Changes:
- Replaced
localwithconstfor module/service references and other single-assignment bindings in several client scripts. - Updated
local functionexamples/usages in a client script and documentation snippets toconst function. - Updated the API reference documentation code samples to match the new
const-based style.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/TopbarIcon.client.luau | Converts module imports and the icon binding to const. |
| src/CoreGuiWarn.client.luau | Converts StarterGui service binding to const. |
| src/ContextAction.client.luau | Converts service/module/constants and the action handler declaration to const. |
| src/Attribution.client.luau | Converts service/version bindings and pcall result bindings to const. |
| docs/api-reference.md | Updates code samples to use const (and const function) for copy-paste examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts usage of local to const when necessary.