fix(rtp): tolerate muxed RTCP on RTP ingress#165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captured RED
Before the production demux was added:
The Sender Report was entering the non-negotiated-RTP-PT counter (and the short RR took malformed-RTP handling), despite real RTP continuing around it.
GREEN
cargo test -p asterisk-sip chime_ -- --nocapture: 2 passedcargo test -p asterisk-sip: 812 unit + 5 parser regression + 8 URI edge + 1 doc passedcargo test --workspace --exclude pjsip-shim: passedcargo clippy --workspace --exclude pjsip-shim -- -D warnings: passedcargo build --workspace: passedAll commands used Rust 1.97.0 and CARGO_BUILD_JOBS=6. No live stack, pods, Helm, trunk, or Docker was used.
Pre-M9 gate
Muxed RTCP is now discarded before RTP ingress hygiene without changing the remote address, SSRC latch, accepted media counters, or discard counters. Separate-port RTCP is independent of the RTP socket. The active SIP channel path does not instantiate the existing RTCP SR builder, so rustisk still emits no Sender Reports; that is report-only and does not block call audio.
The M9 direct-Chime call will not break on RTCP.