fix(sip): accept proxy-rewritten 2xx ACK routes#169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining live Chime Timer-H teardown after #168. Route headers are mutable proxy routing state, not dialog identity, and the prior exact comparison already allowed omission. The matcher retains Accepted state, Call-ID, From/To tags, and INVITE CSeq. Adds production-shaped rewritten-route coverage, wrong-identity negatives, privacy-safe rejection diagnostics, and updates the trunk fixture so E2E exercises the path. Validation: 826 SIP tests, 221 integration tests, and full trunk E2E pass.