Skip to content

chore: address post-merge NUT review comments (W-23400737) #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhefferman-sfdc wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

chore: address post-merge NUT review comments (W-23400737) #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/commands/lightning/dev/helpers/browserUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { Org } from '@salesforce/core';
* @param session - TestSession with a default scratch org.
* @returns The session ID string.
*/
export async function getAccessToken(session: TestSession): Promise<string> {
async function getAccessToken(session: TestSession): Promise<string> {
const scratchOrg = session.orgs.get('default');
const username = scratchOrg?.username ?? '';
if (!username) {
Expand Down
2 changes: 1 addition & 1 deletion test/commands/lightning/dev/helpers/sessionUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const PROJECT_PATH = path.resolve(PLUGIN_ROOT_PATH, 'test/projects/component-pre
// Number of times TestSession will retry scratch org creation before failing. Scratch org
// signup is intermittently flaky (RemoteOrgSignupFailed / C-9999); retrying avoids spurious
// failures in the post-release pipeline. Overridable via TESTKIT_SETUP_RETRIES.
const SETUP_RETRIES = Number.parseInt(process.env.TESTKIT_SETUP_RETRIES ?? '', 10) || 3;
const SETUP_RETRIES = parseInt(process.env.TESTKIT_SETUP_RETRIES ?? '', 10) || 3;

/**
* Restores process.cwd() if it is currently a leaked sinon stub.
Expand Down
Loading