@W-22537853 - Custom CSS CTA links and Use Case 2 and 3 Validation#492
Merged
sf-pallavi-das merged 3 commits intoMay 29, 2026
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mdmehran-qureshi
approved these changes
May 22, 2026
Collaborator
mdmehran-qureshi
left a comment
mdmehran-qureshi
left a comment
There was a problem hiding this comment.
- Method naming doesn't reflect return type — collectStylesheetNamespaceDependencies was refactored to return a boolean, but the method name doesn't hint at this. A name like hasStylesheetNamespaceIssues would be clearer.
- No split for inline-CSS warning — customCssInlineNamespaceWarning was not split into OmniScript/FlexCard variants. Currently only FlexCards use inline CSS, but worth confirming OmniScripts never will.
| customCssStylesheetNamespaceWarningFlexCard: | ||
| 'https://help.salesforce.com/s/articleView?id=xcloud.os_apply_custom_lightning_styles_to_a_specific_flexcard.htm&type=5', | ||
| customCssInlineNamespaceWarning: | ||
| 'https://help.salesforce.com/s/articleView?id=xcloud.os_apply_custom_css_to_a_flexcard_element.htm&type=5', |
Collaborator
There was a problem hiding this comment.
inline css only valid for flexcards?
sf-pallavi-das
approved these changes
May 26, 2026
| "experienceSiteException": "We’ve encountered an exception while processing Experience Cloud sites.", | ||
| "reservedKeysFoundInPropertySet": "The Integration Procedure output uses these reserved keys in the transformation property fields: %s", | ||
| "customCssStylesheetNamespaceWarning": "Custom CSS stylesheet '%s' has namespace references, styles may break after migration.", | ||
| "customCssStylesheetNamespaceWarningOmniScript": "Custom CSS stylesheet '%s' has namespace references, OmniScript styles may break after migration.", |
Contributor
There was a problem hiding this comment.
Let's review with CX
sf-kishore-kurri
approved these changes
May 27, 2026
Contributor
sf-kishore-kurri
left a comment
sf-kishore-kurri
left a comment
There was a problem hiding this comment.
LGTM, but lets get CX review and add the proper CTA links with documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?